cli
cli copied to clipboard
[Feature Request] Hide error output on shutdown
Is your feature request related to a problem? Please describe.
When I stop the dev server, I get error messages. This isn't terrible at the moment, since users have learned to ignore the output, but once we change the default log level to warn, they'll no longer be inured, and may be concerned when they see errors.
$ temporal server start-dev
<normal output>
^C{"level":"info","ts":"2023-03-24T16:13:16.575-0400","msg":"matching client encountered error","service":"frontend","error":"Not enough hosts to serve the request","service-error-type":"serviceerror.Unavailable","logging-call-at":"metric_client.go:218"}
{"level":"info","ts":"2023-03-24T16:13:16.622-0400","msg":"frontend stopped","service":"frontend","logging-call-at":"service.go:368"}
{"level":"warn","ts":"2023-03-24T16:13:16.622-0400","msg":"Failed to poll for task.","service":"worker","Namespace":"temporal-system","TaskQueue":"temporal-sys-tq-scanner-taskqueue-0","WorkerID":"[email protected]@","WorkerType":"WorkflowWorker","Error":"error reading from server: EOF","logging-call-at":"internal_worker_base.go:308"}
{"level":"info","ts":"2023-03-24T16:13:16.622-0400","msg":"RuntimeMetricsReporter stopped","service":"frontend","logging-call-at":"runtime.go:144"}
{"level":"warn","ts":"2023-03-24T16:13:16.622-0400","msg":"Failed to poll for task.","service":"worker","Namespace":"temporal-system","TaskQueue":"temporal-sys-history-scanner-taskqueue-0","WorkerID":"[email protected]@","WorkerType":"ActivityWorker","Error":"error reading from server: EOF","logging-call-at":"internal_worker_base.go:308"}
{"level":"warn","ts":"2023-03-24T16:13:16.622-0400","msg":"Failed to poll for task.","service":"worker","Namespace":"temporal-system","TaskQueue":"temporal-sys-tq-scanner-taskqueue-0","WorkerID":"[email protected]@","WorkerType":"ActivityWorker","Error":"error reading from server: EOF","logging-call-at":"internal_worker_base.go:308"}
{"level":"warn","ts":"2023-03-24T16:13:16.622-0400","msg":"Failed to poll for task.","service":"worker","Namespace":"temporal-system","TaskQueue":"temporal-sys-processor-parent-close-policy","WorkerID":"[email protected]@","WorkerType":"WorkflowWorker","Error":"error reading from server: EOF","logging-call-at":"internal_worker_base.go:308"}
{"level":"warn","ts":"2023-03-24T16:13:16.622-0400","msg":"Failed to poll for task.","service":"worker","Namespace":"temporal-system","TaskQueue":"temporal-sys-processor-parent-close-policy","WorkerID":"[email protected]@","WorkerType":"ActivityWorker","Error":"error reading from server: EOF","logging-call-at":"internal_worker_base.go:308"}
All services are stopped.
{"level":"warn","ts":"2023-03-24T16:13:16.622-0400","msg":"Failed to poll for task.","service":"worker","Namespace":"temporal-system","TaskQueue":"temporal-sys-history-scanner-taskqueue-0","WorkerID":"[email protected]@","WorkerType":"WorkflowWorker","Error":"error reading from server: EOF","logging-call-at":"internal_worker_base.go:308"}
Describe the solution you'd like
When a user hits Ctrl-C, log a newline and then a message, so that the user sees:
<previous output>
^C
Shutting down...
✅ Complete