astroid-framework icon indicating copy to clipboard operation
astroid-framework copied to clipboard

Astroid menu module resets after updating Astroid

Open vtheod opened this issue 1 year ago • 7 comments

Describe the bug After astroid update, the astroid menu module resets it's position from astroid header menu (or astroid header mobilemenu) to status.

To Reproduce Steps to reproduce the behavior: Just puplish an astroid menu module to astroid header menu or to astroid header mobilemenu positions and then update astroid to a later version.

Expected behavior the module's position will be reset

Screenshots Before the update: Before_update

After the update: After_update

System Informations (please complete the following information):

  • Joomla Version: [Joomla 4 & 5]
  • PHP Version [PHP 8.1, 8.2 & 8.3]
  • Astroid Version [e.g. Astroid 3.1.0]
  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]

Additional context Add any other context about the problem here.

vtheod avatar Oct 31 '24 14:10 vtheod

I confirm This happens when updating a template. When discussing 3.1.7 RC talked about this

rinka88 avatar Oct 31 '24 16:10 rinka88

This happens when updating the framework (haven't noticed it with template updates) and it's not recent but it exists also in previous versions of astroid.

vtheod avatar Oct 31 '24 18:10 vtheod

This happens when updating the framework (haven't noticed it with template updates) and it's not recent but it exists also in previous versions of astroid.

by the word template I meant framework

rinka88 avatar Oct 31 '24 18:10 rinka88

@rinka88 @vtheod It's my mistake. I will fix it in the next version. Please wait for the update.

sonvnn avatar Nov 01 '24 06:11 sonvnn

@vtheod @rinka88 I fixed this issue at https://github.com/templaza/astroid-framework/commit/6f99ee765bceb6f7bd0ed332254dfefaf9898506 Please help me download v3-branch and test it.

Best Regards, Sonny

sonvnn avatar Nov 01 '24 07:11 sonvnn

I installed it and it seems that the issue is fixed. Thanks @sonvnn I just noticed that after installation, the icon in the get started button doesn't display:

Screenshot 2024-11-01 at 09-56-50 Extensions Install - Administration

vtheod avatar Nov 01 '24 08:11 vtheod

thanks for the correction

rinka88 avatar Nov 01 '24 09:11 rinka88