tempest-framework icon indicating copy to clipboard operation
tempest-framework copied to clipboard

Published 20 hours ago • verified publisher icon tempestphp

[CI] update Github Action worksflows

Open Treggats opened this issue 1 year ago • 8 comments

This PR simplifies the Github Action workflows.

It has parts of #317 in it. And as such it does not fully resolve it.

The database addition to the CI requires some more work so that will be a separate pull request.

Changes

  • remove quality-control.yml, was pretty much redundant
  • move the fixing the style to the quality-assurance.yml workflow
  • add rector to the composer qa scripts
  • add rector to the CI

Note Github Actions are notorious hard to test, but in this case the runs on my fork can be seen as tests.

Treggats avatar Aug 12 '24 21:08 Treggats

Pull Request Test Coverage Report for Build 10672817981

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 80.532%
Totals Coverage Status
Change from base Build 10666395736: 0.1%
Covered Lines: 4447
Relevant Lines: 5522
💛 - Coveralls

coveralls avatar Aug 12 '24 21:08 coveralls

I would submit a separate PR to fix the Rector run and any changes to the bootstrap files just to keep this one clean.

As mentioned in #317, I wouldn't really be inclined to combine the two QA files right now.

aidan-casey avatar Aug 13 '24 01:08 aidan-casey

I would submit a separate PR to fix the Rector run and any changes to the bootstrap files just to keep this one clean.

As mentioned in #317, I wouldn't really be inclined to combine the two QA files right now.

Fair enough, updated to only have added Rector and disabled it for now.

Treggats avatar Aug 13 '24 06:08 Treggats

@aidan-casey will you merge this or do you need my input as well?

brendt avatar Aug 15 '24 04:08 brendt

@brendt I'll review today and get it merged.

aidan-casey avatar Aug 15 '24 10:08 aidan-casey

@Treggats - Can you also rebase?

aidan-casey avatar Aug 15 '24 13:08 aidan-casey

@aidan-casey Rector is failing because it wants to change two files.

Treggats avatar Aug 15 '24 14:08 Treggats

@Treggats - I'm not a huge fan of the fact that Rector isn't showing us what it would change. Let's update the action to include that.

aidan-casey avatar Aug 15 '24 15:08 aidan-casey

Nice! Does postgres actually work? I couldn't get it to work locally (tests were failing due to not being able to drop the database).

Also: now that the qc and qa action are merged into one, does that mean that style changes will always be committed? That's kind of annoying for PRs. I'd say style checking and committing should only happen on main.

brendt avatar Sep 04 '24 05:09 brendt

@brendt

Nice! Does postgres actually work? I couldn't get it to work locally (tests were failing due to not being able to drop the database).

The tests are passing, so I guess xD don't think I've tested it locally.

Also: now that the qc and qa action are merged into one, does that mean that style changes will always be committed? That's kind of annoying for PRs. I'd say style checking and committing should only happen on main.

The style committing only happens on the quality control (push to main or manual run). The quality assurance does a dry run.

Treggats avatar Sep 04 '24 10:09 Treggats

Let's merge!

brendt avatar Sep 04 '24 10:09 brendt