tempest-framework icon indicating copy to clipboard operation
tempest-framework copied to clipboard

Finalize `NullShellExecutor`

Open aidan-casey opened this issue 1 year ago • 1 comments
trafficstars

The NullShellExecutor is currently tested using mocks. This prevents us from making the class final.

We should revise the tests for that class and finalize the class.

aidan-casey avatar Jun 04 '24 10:06 aidan-casey

Hey there, can you assign this issue to me and open a branch for it? I would like to work with you. This seems like a good issue to start with.

Qupiter avatar Jun 21 '24 08:06 Qupiter

Hi @aidan-casey !

This issue can be closed, isn't it? If I'm right the NullShellExecutor class is final.

Thank you! 😃

alibori avatar Sep 22 '24 09:09 alibori

Hey, @alibori! It is final, but has no tests. We still need to refactor so we can test it. 🙂

aidan-casey avatar Sep 22 '24 10:09 aidan-casey

No no, I fixed that, just forgot to close the issue

brendt avatar Sep 22 '24 11:09 brendt