tempest-framework icon indicating copy to clipboard operation
tempest-framework copied to clipboard
verified publisher icon tempestphp

Regex performance issues when using our wrapper

Open brendt opened this issue 9 months ago • 2 comments

I ran into an issue where using our regex wrappers caused a regex JIT overflow, using PHP's built-in regex function worked fine. Here's the PR that shows the diff: https://github.com/tempestphp/tempest-framework/pull/1015/files

brendt avatar Mar 14 '25 10:03 brendt

Do you have an example value for $contents so I can reproduce and debug? Our wrapper doesn't do anything crazy, it's just error handling

innocenzi avatar Mar 14 '25 11:03 innocenzi

This was on tempest-docs, I didn't dig deeper into it yet. Simply replace the regex call and run the console to get the error. But I'm happy to debug it myself later, I just made the issue so that I wouldn't forget.

brendt avatar Mar 14 '25 13:03 brendt

Is this still relevant? I think this PR essentially closes this issue.

xHeaven avatar Jun 19 '25 15:06 xHeaven

Yes possibly. Let's go ahead and close 👍

innocenzi avatar Jun 19 '25 15:06 innocenzi