tempesta
tempesta copied to clipboard
fix(1346): fix control frames flood
part of #1346
I think that it is better to implement new counter in frang and check max count of control frames as we do for all other limits in frang.
I think that it is better to implement new counter in frang and check max count of control frames as we do for all other limits in frang.
Maybe global configuration is better than frang? Just like "http_max_header_list_size", it should apply to all HTTP/2 connections regardless of virtual host, and it is not a request response related parameter.
I think that it is better to implement new counter in frang and check max count of control frames as we do for all other limits in frang.
I don't see much sense to move it to frang. 1. There is no appropriate frang handler. 2. We don't need history. 3. We have http_max_header_list_size that is not belong to frang as well.
I think that it is better to implement new counter in frang and check max count of control frames as we do for all other limits in frang.
I don't see much sense to move it to frang. 1. There is no appropriate frang handler. 2. We don't need history. 3. We have
http_max_header_list_sizethat is not belong to frang as well.
However also there is one disadvantage of using it outside the frang, we can't configure ip_block for ping flooding. And this could be the deciding factor for moving it to frang.