tempesta icon indicating copy to clipboard operation
tempesta copied to clipboard

Prohibit DELETE method in default configuration #2058

Open biathlon3 opened this issue 1 year ago • 4 comments

My first attempt, I am not sure that it is the best solution, but it seems to work.

biathlon3 avatar Mar 13 '24 09:03 biathlon3

You should also fix tests, where DELETE method is used by adding appropriate DELETE method to frang config

EvgeniiMekhanik avatar Mar 14 '24 08:03 EvgeniiMekhanik

Please remove todo from http_limits.c, when you will rebase. TODO: Remove when PR #2078 merged

const-t avatar Apr 04 '24 07:04 const-t

Please implement a workaround for #2119 with a TODO comment

krizhanovsky avatar May 14 '24 16:05 krizhanovsky

Please implement a workaround for #2119 with a TODO comment

I manage to do it in normal way.

biathlon3 avatar May 21 '24 12:05 biathlon3

A want to ask you to check following(and others similar conditions) part in tfw_http_req_process():

if (res.type == TFW_HTTP_RES_REDIR) { tfw_http_req_redir(req, res.redir.resp_code, &res.redir); return T_OK; }

In this case we don't freed split skb as well. To check it just use redirects.

http_chain redirects {
    # Absolute path
    uri == "/company.html" -> 301 = https://tempesta-tech.com/company;

    # Use variables
    uri == "/blog/" -> 308 = https://$host/$request_uri/;

    # Relative path
    uri == "*/services.html" -> 303 = /services;

    # Temporal redirection for the default index page only to a temporal landing page.
    uri == "/" -> 307 = /c++-services;
}

const-t avatar May 31 '24 10:05 const-t

This PR was replaced by PR #2139

biathlon3 avatar Jun 28 '24 05:06 biathlon3