tds-core icon indicating copy to clipboard operation
tds-core copied to clipboard

fix(esm): require is not defined when creating esm modules.

Open MetaMmodern opened this issue 3 years ago • 0 comments

Description

That piece of CJS was breaking vite(esbuild) production build. I tried fixing it the way as in this PR in the build file of your package and it worked. Only thing is left to check the build by rollup whether that works well. And also to the commented TODO issue in rollup: last comment in that issue states that it's not an issue anymore. Anyone can run tests on this? I'm not part of this project, need active contributors' support here.

Checklist before submitting pull request

  • [ ] New code is unit tested
  • [ ] Commits follow our Developer Guide
  • [ ] For code changes, run npm run prepr locally
  • [ ] make sure visual and accessibility tests pass

MetaMmodern avatar Dec 28 '21 13:12 MetaMmodern