teltek
Feature #487 #524
If galicaster restarts during a recording, on the next long heartbeat with an iCal update if the recording should still be happening it is resumed. once the recording is finished any track files belonging to the recording in rectemp are concatenated with ffmpeg and put into the correct mediapackage to then be ingested. there is also an option to delay the file concatenation and ingest until nightly time (this is to allow a recording in quick successtion to not wait for this job to complete)
[repository]
recoverytype = save
[plugins]
checkrepo = True
[checkrepo]
to_merge = True
delay_merge = False
its important to note some changes were made to galicaster behaviour around file recovery to accomadate this. on galicaster restart autorecover 'full' recoverytype was always active, this has now been made configurable via the 'autorecover' option as with error handling. and for this plugin should be set to 'save' only manual recordings should be given a prefix of "Recovered - " when autorecovered as this changes metadata for opencast scheduled recordings. maybe this information is better in the galicaster.xml if UI notification of a recovered MP is needed. this is not addressed here
I'm sorry, i do realise this is a large pile of code. if more explanation is needed or a demo please let me know.
If it were suggested that this work be done in another way or the plugin made separate from the core code i'd be up for that as a discussion
@androidwiltron I'll get to testing this ASAP, but looks good from a quick glance (and very useful!).
One thing i noticed - is there a particular reason for depending on ffmpeg rather than using the gstreamer concat element?
@androidwiltron I'll get to testing this ASAP, but looks good from a quick glance (and very useful!).
One thing i noticed - is there a particular reason for depending on ffmpeg rather than using the gstreamer
concatelement?
really the reason is historical. at the time first written it was gst0.1 still and the stability wasn't 100% and not the best at concatenating certain file types. i think i should look at gst concat again as things have moved on
Hi @androidwiltron, do take a look at my colleague comments. I have finally been able to take a look at this and I think we should be able to merge it on master, save a few details.
Sorry for taking so long.
docs added https://github.com/teltek/Galicaster-doc/pull/16 https://github.com/teltek/Galicaster-doc/pull/15
Hi @androidwiltron
Good work! Do also remember to check the tests to make sure they're not failing before we merge this to master.
Hi @androidwiltron
Good work! Do also remember to check the tests to make sure they're not failing before we merge this to master.
oh yes we have tests these days! let me take a look