Consider publishing an updated release

[fwgreen]

I've been trying to build the current master, but I'm encountering problems at runtime:

Error occurred during initialization of boot layer
java.lang.module.FindException: Module client not found, required by org.postgresql.adba

I'm not very good with Maven so I'm giving up.

[alexanderkjall]

Hi

This is something that needs to be handled before the next release, the problem is that the scram project doesn't have module support and I didn't want to reimplement all that crypto code.

I have opened a pull request in that project, but so far no response: https://github.com/ongres/scram/pull/5

I need to either fork and do my own release of the scram project or copy those source files into this project and both of those options come with drawbacks.

[fwgreen]

Maybe it would be enough to add an Automatic-Module-Name to the manifest of each project?

<plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-jar-plugin</artifactId>
  <configuration>
    <archive>
      <manifestEntries>
        <Automatic-Module-Name>com.ongres.scram.client</Automatic-Module-Name>
      </manifestEntries>
    </archive>
  </configuration>
</plugin>

The maintainers might be more amenable to this, less drastic, change.

[alexanderkjall]

That is a great suggestion, I'll update my pull request with that as soon as I get some free time.

On another note, what version of maven do you use to build? I have no problem building master with maven 3.6.0 and java 10.

[fwgreen]

I'm also using Maven 3.6.0, but on Java 11. I think support for 10 ended when 11 was released.

[fwgreen]

@alexanderkjall Has there been any recent communication between the pgjdbc team and the ongres scram maintainers? I get the feeling that https://github.com/ongres/scram has been abandoned.

[davecramer]

@fwgreen What is needed in scram ?

[fwgreen]

@davecramer It seems to not be compatible with Java 11 and the JPMS in its current form.

[davecramer]

I'm pinging Alvaro.. will let you know

[alexanderkjall]

I emailed Alvaro before christmas and asked if he was willing to merge the request but was busy with real life and would get around to it.

Maybe he forgot it, otherwise I guess that I will need to fork that project in some way.