TLYShyNavBar icon indicating copy to clipboard operation
TLYShyNavBar copied to clipboard

Use KVO to automatically respond correctly to changes in the extensionView size

Open evands opened this issue 8 years ago • 4 comments

Observe the frame of our extensionView and update automatically if it changes.

evands avatar Feb 29 '16 04:02 evands

Thanks for the PR! I am working on some more examples in the demo, especially refresh and hopefully one where the extension view frame changes to demonstrate this. Once I create the example, I'd also want to explore subclassing UIView and using layoutSubviews instead of KVO to react to frame changes, since KVO is something I generally like to avoid.

Mazyod avatar Feb 29 '16 14:02 Mazyod

Just a note that this remains an issue. I recently moved to using your newly refactored version (1.1.0) to get the corrections for a couple bugs and verified it remains. It'd be great to get this merged; in the meantime, I'm manually updating extensionViewContainer's frame via a category after I change the extension view size.

evands avatar Aug 23 '16 15:08 evands

Is this supposed to work now? I'm trying to change my extension frame size and nothing is happening

StainlessStlRat avatar Nov 18 '17 07:11 StainlessStlRat

I revisited this a month or so ago and it remained nonworking.

evands avatar Nov 18 '17 11:11 evands