Problem with target group name

[colincoleman]

Bug report

After pulling in all the changes to telia-oss to our fork we ran into an issue where using a long name_prefix caused error saying the name of the target group had to be 32 chars or less.

Looking further I see that this commit https://github.com/telia-oss/terraform-aws-ecs-fargate/commit/ab479e29aaa96f27993ba18057fa79706ca1b93e added a name for the target group.

This was originally intentionally excluded and instead the name_prefix and port number are added as tags. There is still a comment in the code above the addition of the tags as to why this was done.

Steps to reproduce

I haven't tried to confirm that the dynamic name and the create_before_destroy lifecycle policy are still necessary to avoid errors when making changes but I expect they are.

Either way there is an inconsistency in the codebase between the comment and the re-addition of the name parameter