Bug: Silently ignoring errors when access_token has wrong scope

Open itsdalmo opened this issue 7 years ago • 1 comments

Ref https://github.com/telia-oss/github-pr-resource/issues/48, it seems like check is silently ignoring errors (when the scope of the access_token did not grant private repository access. Most likely a 404 was returned, but whichever error was returned should have been output in the task and resulted in a non-zero exit code.

Oct 26 '18 08:10 itsdalmo

I believe this might be related: https://github.com/shurcooL/githubv4/issues/41. However, the Query() implementation should bubble up errors for non-200 status codes from the underlying client - and I would expect a 404 not found to be returned if the access token has the wrong scope 🤔

Apr 02 '19 20:04 itsdalmo