github-pr-resource icon indicating copy to clipboard operation
github-pr-resource copied to clipboard

Published 20 hours ago • verified publisher icon telia-oss

only count reviews from authors who can push to the repository

Open Benjamintf1 opened this issue 3 years ago • 2 comments

Benjamintf1 avatar Jul 19 '22 20:07 Benjamintf1

As it stands, prs can be approved by basically anybody at all, and doesn't take into account status. So if you're using approval_count it likely isn't gating what you think it's gating.

We tested this against a small pipeline, and it seems to work fine.

Benjamintf1 avatar Jul 19 '22 20:07 Benjamintf1

image sorry, docs wern't very explicit, authorCanPush *does* to the destination repo and not the source repo.

Benjamintf1 avatar Jul 20 '22 15:07 Benjamintf1

closing this, seems to be unmaintained.

Benjamintf1 avatar Feb 08 '23 23:02 Benjamintf1