github-pr-resource icon indicating copy to clipboard operation
github-pr-resource copied to clipboard

Missing PR's

Open jdziat opened this issue 2 years ago • 5 comments

We're noticing on some of our higher volume repositories that we get occasional missed PR's that never build in concourse. In order to work around this the developers have to push a second commit to trigger the build. It's currently setup to use a webhook trigger as well as the default polling method.

jdziat avatar Aug 06 '21 13:08 jdziat

I think I just experienced this as well, where PR A was updated with a force-push to its branch while PR B was opened fresh a couple minutes later. Manually triggering a check on the resource doesn't seem to help.

rosenhouse avatar Aug 09 '21 21:08 rosenhouse

@rosenhouse The unfortunate part is the only workaround i can think of is implementing some sort of persistent key value mechanism to track these commits to make sure they're always built. Hopefully i'm missing something fairly obvious though.

jdziat avatar Aug 09 '21 21:08 jdziat

Based on the description you are likely running up against #26. There are a couple PRs under review that would address that issue, but in the meantime one way to get the resource to notice PRs that it missed is by running the following commands on your PR branch:

git commit --amend --no-edit # Updates commit timestamp without modifying commit contents
git push -f origin head # Force-push your PR branch; proceed with caution so you don't accidentally overwrite something you didn't mean to

ctreatma avatar Aug 10 '21 17:08 ctreatma

@ctreatma Right, that’s not the best developer experience though.

jdziat avatar Aug 10 '21 18:08 jdziat