github-pr-resource icon indicating copy to clipboard operation
github-pr-resource copied to clipboard
verified publisher icon telia-oss

PR resource is not getting picked after adding a label .

Open Plavhate-ford opened this issue 5 years ago • 3 comments

I have my pipeline which refreshes the PR list after every 5sec. Also, it uses the GitHub label "LGTM" to filter the PRs. Now I have PR #1 without the "LGTM" tag. And PR #2 generated after PR1, with LGTM tag. After the pipeline is refreshed and PR2 is picked by concourse, I added the label "LGTM" to PR#1. But now the pipeline is not showing PR#1.

  • name: my_pr type: github-pr source: repository: ********* access_token: ((token)) labels: ["LGTM"] check_every: 5m

Plavhate-ford avatar Dec 02 '20 22:12 Plavhate-ford

This has been blocking us, can anyone help on this?

Plavhate-ford avatar Dec 10 '20 16:12 Plavhate-ford

This sounds similar to https://github.com/telia-oss/github-pr-resource/pull/189. I'm not sure if that would also fix the issue with labels, but I think it might?. We are currently running a version of the resource with #189 merged into it until it is that fix is merged upstream, to avoid similar PR issues with out of order commits.

jhosteny avatar Dec 18 '20 18:12 jhosteny