kendo-ui-core icon indicating copy to clipboard operation
kendo-ui-core copied to clipboard

The TagHelper code is not correct

Open DoomerDGR8 opened this issue 3 years ago • 3 comments

There is a mix of a closing tag for the first item. Here is the corrected code:

<kendo-breadcrumb name="breadcrumb" delimiter-icon="line">
    <kendo-breadcrumb-items>
        <kendo-breadcrumb-item type="BreadcrumbItemType.RootItem" text="All Components" href="https://demos.telerik.com/kendo-ui/" show-text="true" icon="globe" show-icon="true"></kendo-breadcrumb-item>
        <kendo-breadcrumb-item type="BreadcrumbItemType.Item" text="Breadcrumb" href="/breadcrumb" icon="gear" show-icon="true"></kendo-breadcrumb-item>
        <kendo-breadcrumb-item type="BreadcrumbItemType.Item" text="Tag Helper" href="/tag-helper" icon="cloud" show-icon="true"></kendo-breadcrumb-item>
    </kendo-breadcrumb-items>
</kendo-breadcrumb>

DoomerDGR8 avatar Aug 05 '22 08:08 DoomerDGR8

Hi @DoomerDGR8,

I reviewed the code and it looks correctly defined. There are is a kendo-breadcumb-items tag (opened on line 63 and closed on line 67) that contains three kendo-breadcrumb-item tags.
Let me know if I am missing something.

VicTachev avatar Sep 15 '22 13:09 VicTachev

Hi @DoomerDGR8,

I reviewed the code and it looks correctly defined. There are is a kendo-breadcumb-items tag (opened on line 63 and closed on line 67) that contains three kendo-breadcrumb-item tags. Let me know if I am missing something.

I have no o idea where I was when I reported this. I just went to the overview and noticed the second code block in TagHelper view:

image

Can you see the little red highlight?

DoomerDGR8 avatar Sep 16 '22 15:09 DoomerDGR8

@DoomerDGR8 Thank you for the clarification. I missed that when I first reviewed the change.

In order for us to be able to merge the change you suggested we need you to first sign our CLA. Thank you :)

VicTachev avatar Sep 20 '22 14:09 VicTachev