kendo-themes icon indicating copy to clipboard operation
kendo-themes copied to clipboard

Move the ::before element inside the k-list-item-text to a different place

Open gdenchevprog opened this issue 2 years ago • 3 comments

Is your feature request related to a problem? Please describe.

With the new ListBox rendering, there's extra space above each item when the content of the item is surrounded in <p> tags.

Run the following Dojo example to observe the described behavior:

https://dojo.telerik.com/@gdenchev/useSUvaz

Screenshot: image

It seems like the extra space comes from the ::before element inside the k-list-item-text span.

image

Describe the solution you would like to see implemented

The proposal is to see if it's possible to move the ::before element to a different place or remove it altogether.

gdenchevprog avatar Aug 11 '22 08:08 gdenchevprog

Mentioned again in the following forum thread: https://www.telerik.com/forums/listbox-item-template#5627782

gdenchevprog avatar Mar 16 '23 10:03 gdenchevprog

Also reported in ticket #1613362

martintabakov avatar Jun 26 '23 14:06 martintabakov

The mentioned :before element was added in order to address a problem with wrong height of empty list items: Issue: https://github.com/telerik/kendo-themes/issues/3388 Fix: https://github.com/telerik/kendo-themes/commit/ebd716e8ca576719b6d9a574676e0d1d4e7c6c3c

With the current list implementation there are not many options to handle all scenarios - default item, empty item, item with template, empty item with template with CSS only. After a deep investigation, we believe the "correct" direction is to use the new lh unit, however it is not supported in all major browsers yet. Therefore we will postpone the fix for the current issue until the lh unit has full support.

inikolova avatar Oct 25 '23 15:10 inikolova