kendo-react icon indicating copy to clipboard operation
kendo-react copied to clipboard

Add role='dialog' to Window component similar to Dialog

Open gusgard opened this issue 3 years ago • 0 comments

In the Dialog component we have a value for role Dialog.tsx

 <div
                {...aria}
                className="k-widget k-window k-dialog"
                role="dialog" <----- we have a value
                style...
                  >

but in the Window component, we don't have it. Window.tsx

              <div
                role="dialog" <----- we need to add this!
                {...{[DATA_DIALOGS_ID]:this._id}}
                tabIndex={0}
                onFocus={this.onFocus}
                onBlur={this.onBlur}
                onKeyDown={this.onKeyDown}
                ref={(el) => {
                    this.windowElement = el;
                    this.element = el;
                }}
                className={classNamesWindow}
                style={{
                        top: this.top, left: this.left, width: this.width, height: this.height || '',
                        zIndex: currentZIndex,
                        ...this.props.style
                    }}
                >

We just need to add role="dialog" to the Windows.tsx component, this will be helpful for integration tests

gusgard avatar Jun 29 '22 16:06 gusgard