teleport-code-generators icon indicating copy to clipboard operation
teleport-code-generators copied to clipboard

UIDL from the examples/project.json generates undefined links in the output.

Open JayaKrishnaNamburu opened this issue 5 years ago • 7 comments

The UIDL that we are currently using from the examples/project.json folder is generating #undefined links.

        <textblock>
          <a href="#undefined">
            <span className={styles.text}>Get Started →</span>
          </a>
        </textblock>

JayaKrishnaNamburu avatar Jun 02 '20 06:06 JayaKrishnaNamburu

@JayaKrishnaNamburu to what I understand from https://github.com/teleporthq/teleport-code-generators/blob/master/packages/teleport-types/src/uidl.ts#L207 content doesn't accept id key it accepts section, replacing id with section resolves it, but I'm still getting several errors mostly around components which have type: 'local' when I run npm run standalone, are these 2 problems related?

dhrubesh avatar Jun 06 '20 10:06 dhrubesh

Hi @dhrubesh a recent update to master introduced this issue. The project.json needs some updates to run in the current master. I have handled it to run properly in an open pr. feature/reusable-styles. Which we will be merging soon. Please use that PR, if you want to get along the project till it gets merged in master. 😀

JayaKrishnaNamburu avatar Jun 06 '20 11:06 JayaKrishnaNamburu

@JayaKrishnaNamburu Looks like this issue resolved in feature/reusable-styles.

dhrubesh avatar Jun 06 '20 11:06 dhrubesh

Yes, i solved it. Just waitjng for it to merge. You can use it for now to understand the code 😀

JayaKrishnaNamburu avatar Jun 06 '20 11:06 JayaKrishnaNamburu

@JayaKrishnaNamburu I think https://github.com/teleporthq/teleport-code-generators/commit/b68472b845d76c08600370bea572e36c1d52baed this commit resolves it. Anyways, let me know if there are any more good first issue, I'll be happy to spend some time 😃

dhrubesh avatar Jun 06 '20 11:06 dhrubesh

That's the commit which actually introduced this, the current open PR solves it.

JayaKrishnaNamburu avatar Jun 06 '20 12:06 JayaKrishnaNamburu

Hi @dhrubesh the PR is closed now, and you can replicate this issue directly on master. Let me know if you want to have a shot at this issue, and if needed some help :smile:

JayaKrishnaNamburu avatar Jun 11 '20 13:06 JayaKrishnaNamburu