Julian Rohrhuber comments

Results 802 comments of


                                            Julian Rohrhuber

multichannel expansion on ODE systems?

Oh yes, most definitely. I'll fix this. Are you aware of any other such case?

move variable declarations outside inlined functions

Very good, thank you!

move variable declarations outside inlined functions

will you also merge it here?

move variable declarations outside inlined functions

Yes, I also have had my issues in the past, of course. So how do you get the changes into your local repository? I would find it the easiest just...

move variable declarations outside inlined functions

Yes, sure it doesn't sound ridiculous at all. The main thing about git is that it makes collaboration easy and rewarding (that is, you have improvements as soon as you...

move variable declarations outside inlined functions

> (I never see these warnings by the way, also I have forgotten what makes them visible) By the way, it is useful to just switch them on, either in...

when a user has no name, it deadlocks the network

Somewhere in ``` add {|peer| peer = peer.as(Peer); dict[peer.name] = peer; peer.addDependant(this); this.changed(\add, peer) } ``` we may have to check if it is duplicate with ref to IP address

when a user has no name, it deadlocks the network

Yes, if it warns once, this would be enough.

AddrBook sendExcluding, sendAll, etc. throw an error if a host has left the network

@muellmusik After this https://github.com/supercollider/supercollider/pull/2908#discussion_r119858749 has been merged, do you think this can now be caught?

AddrBook sendExcluding, sendAll, etc. throw an error if a host has left the network

great, this will be very useful!