testerra icon indicating copy to clipboard operation
testerra copied to clipboard

Link timings and tests

Open selinanatschke-mms opened this issue 1 year ago • 2 comments

Description

  • new filter functionality including a list of chips that are displayed below the usual filter selections and show what filters are currently used
  • available chip types: clear all, status, class, custom text (free text search), custom filter (when navigating from timings or failure aspects view)
  • chips can be removed by clicking on the chip or using the clear all chip
  • added chipNameValueConverter
    • uses classNameValueConverter and statusNameValueConverter
    • differentiates text on the chip or tooltiptext
  • added chipClassValueConverter for color encoding
    • color encoding: blue for status filter chips, turquoise for class filter chips, purple for free text search chips, defautl grey for all other chip types
  • implemented functionality to search classes with free text
  • after filtering classes the chosen classes will not appear in select box anymore
  • when navigating from timings view: click on a bar => navigate to test view + methods that are represented in bar are filtered in tests view
  • when navigating from failure aspects view:
    • click on failure aspect: methods with that failure aspect are filtered
    • click on "failed" badge: methods with that failure aspect are filtered and "failed" status is filtered

image

Fixes # (issue)

  • alphabetically sort filter class select options

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

selinanatschke-mms avatar Feb 28 '24 13:02 selinanatschke-mms

I found some issues:

  • [ ] Clicking on a class bar on dashboard should show a filtered test list. But currently the status is not set correctly: image
  • [ ] The place between the select boxes and the test table is not big enough. After settting a filter the table is moved down by some pixels. I suppose to keep enough place for the first row of chips to prevent a "shaky" page.
  • [ ] The text searches are compined with OR but needs to be combined with AND.
  • [ ] Please have a look to the report tests which need an update. Maybe we also need some additional tests.

martingrossmann avatar Feb 29 '24 08:02 martingrossmann

Please create new branches in the future and do not reuse old ones.

mreiche avatar Mar 01 '24 08:03 mreiche

@mreiche From my side its ok and ready to merge.

martingrossmann avatar May 22 '24 13:05 martingrossmann