scale
scale copied to clipboard
telekom
feat: added tooltip and scale-icon in data-grid button
This feauture implements extension for the data-grid action cells to add tooltip and icons to the configured rows. This addresses the Issue 2236 that requested such feature. The tooltip and icons use the existing icon and tooltip feature from the scale button. Reviews are appreciated.
Deploy Preview for marvelous-moxie-a6e2fe failed.
| Name | Link |
|---|---|
| Latest commit | 2dc9de09d579f8577de1ce495dadb977e2d35c2a |
| Latest deploy log | https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/6613bb1a066a9a0008423799 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks for the PR! There are some build errors. Would you please have a look and fix them?
@maomaoZH I have pushed the committed changes. There were some checks executed first time i created the pull request e.g. prettier, visual tests etc. Now I made some changes and pushed new commits to this pull request. Could you please let me know how these checks can be executed again in order to say now everything is ok?
@acstll @felix-ico Could you please approve for the pipeline to run or do I need to do anything in order for pipelines to run?
HI @sameetah looks like build-pr / prettier and build-pr / uncommitted-changes are still failing. To fix the first one you should run yarn format and commit the changes, for the second one yarn build and commit the changes. build-pr / visual-tests (pull_request) should be OK to ignore, if there have been no visual changes in the components
@acstll @felix-ico I have addressed the issues mentioned. For the 'build-pr/prettier' error, I ran 'yarn format' locally and committed the changes. For the 'build-pr/uncommitted-changes' error, I ran 'yarn build' locally and committed the changes. The changes have been pushed to the branch. Could you please review again? Thank you!
@sameetah the uncommited-changes job is still failing, could you make sure that all files have been commmited?
also, could you check if it's possible to remove the skipLibCheck you added?
@sameetah I copied your changes in a separate branch, and removed that tsconfig rule, all checks seem to pass there...https://github.com/telekom/scale/pull/2308
@felix-ico I removed the skipLibCheck rule in tsconfig file. Could you please have a look and see if checks pass now?
@felix-ico The uncommitted changes are a single read me that is auto generated during the build process. All my changes are committed when I push so how do I account for the build script?
@sameetah the build process should be the same locally and on CI, perhaps you commited something that is not part of this task (I wonder why the readme for chart-stack-card changes, when you have touched no code there) also comparing to the PR i opened, you can see a lot less files are committed...perhaps they are leftovers from previous code changes?
@felix-ico Could you please now check if the uncommitted changes check is passing? I made some changes and this should hopefully work
@sameetah now you need to run yarn format and yarn build in packages/components again...