scale icon indicating copy to clipboard operation
scale copied to clipboard

Published 20 hours ago • verified publisher icon telekom

fix: add controlled prop

Open felix-ico opened this issue 3 years ago • 2 comments

So using the same approach as in the dropdown fixes this react/reactivity issue, I guess this would need to be added to some other components as well to avoid the same issue in the future (at least in text-area).

felix-ico avatar Jul 15 '22 11:07 felix-ico

Your Render PR Server URL is https://telekom-scale-storybook-preview-pr-1140.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cb8lbus41lsd7r62d640.

render[bot] avatar Jul 15 '22 11:07 render[bot]

I got confused with the many "conversations" I opened in the comments, haha, sorry 🙏

acstll avatar Aug 11 '22 06:08 acstll

@acstll all CI jobs are passing now, snake_case doesn't work so i changed it to experimental-controlled.

I also added the prop to storybook, but there is no real documentation on why/how someone would use it. Should that be included in storybook as well? or maybe just in the readme?

felix-ico avatar Aug 18 '22 15:08 felix-ico