folders' unread counter counts unread topics instead of unread chats

[RememberTheAir]

Steps to reproduce

1. create a folder
2. manually include some chats and at least one topic chat
3. wait for some messages to be sent in one of the non-topic chats and in 2+ topics

It's probably important to mention that I have the "count unread messages" option disabled, so the app counts chats instead of messages

Expected behaviour

The folder's unread counter counts the number of unique chats

Actual behaviour

The unread counter's count is the result of the sum of unread non-topic chats and the number of single unread topics. For example, let's say we have three unread chats in a folder: A, B, C. A and B are normal chats, while C is a topic chat, and there are three unread topics in this chat. The unread counter will show that there are 5 unread chats in this tab: 1 + 1 + 3

This might be the intended behavior on desktop, but it's inconsistent with mobile apps, where single chats are counted

Operating system

Windows 10

Version of Telegram Desktop

4.6.2

Installation source

Static binary from official website

Logs

No response

[SpL1Ne]

Also, if you don't check chat with topics long enough, it won't count as unread chat at all. I have 4 chats in folder, 1 chat with topics. And folder shows 3 unreaded chats instead of 4 (or instead 3 + number of unreaded topics).

[RememberTheAir]

bump, this is still a distracting inconsistency with the mobile apps

[dajotim937]

Related issue with notification: Screenshot 1 and 2: Chat with unread topics doesn't count in folder unread counter. Screenshot 3: Open any topic, now we have unread counter for this topic Screenshot 4: Now chat is counted in unread counter.

Screenshots

[RememberTheAir]

this still works differently than the Android/iOS app. Is this intended?

[RememberTheAir]

any comment on this? it looks like it is not considered a bug, just wanted to make sure that the fact that from android my folder unread counter says 1 and from desktop it says 12 is intended

[github-actions[bot]]

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

[RememberTheAir]

unstale, the mobile apps still behave differently

[kyak]

I just want to add that this issue is indeed very inconvenient.

[RememberTheAir]

yes, this needs to be fixed either here or on the mobile apps. @john-preston is this intended and going to stay this way?

[RememberTheAir]

any news? :(

[ciltocruz]

no news?

[23rd]

This change can have a number of nuances, so it would be helpful if you tested a bit on how it works.

https://github.com/telegramdesktop/tdesktop/actions/runs/12012513096

[dbsergey]

Fixed for me

[dsent]

Commit f888008 seems to break counting of muted groups with topics (or groups with some topics muted, and some unmuted) in a lot of ways at the same time. The numbers seem to be subtracted from the unread count, not added. Additionally, triggers displaying of unread counters on folders as blue (active) even if all groups are muted. Makes things even more interesting if you disable counting of muted chats in folder badges. With 5.8.3: With the commit in question: With the muted counting disabled:

[dsent]

Having some topics muted, and some unmuted is a very real and important use case. We have three possible states of a group with topics, from the notification standpoint:

1. There are new messages in the unmuted topics of the group. The status for the whole group = +1 count, unmuted (blue).
2. No new messages in the unmuted topics, new messages in the muted topics. Group status = +1 count, muted (gray).
3. No new messages in any topics. Group status = 0

[dsent]

If counting messages is enabled, it gets messier. But still, you have to distinguish between having new messages in unmuted and muted topics, and give blue notifications only if there are new messages in the unmuted topics.

Sorry if I'm stating the obvious 🙏

[23rd]

@dsent Thanks for your detailed feedback. Can you take a look at a new test build? https://github.com/telegramdesktop/tdesktop/actions/runs/12044613567

[dsent]

@23rd this one seems to work correctly! “Count unread messages” seems to affect only the window/taskbar title, not the folder badges, but I guess this was how it always worked.

[ciltocruz]

Sorry to butt in on the conversation. I don't know if this issue is related to my question, if not, please let me know and I'll open a new one.

In the desktop app, the unread message counter in a folder is correct if the chats in that folder are private conversations or simple groups, but it is not correct if what is in that folder is a group with topics.

Let's suppose 1 folder with 1 group that has 10 topics. In all of them there are unread messages. It doesn't matter how many of those messages add up, the unread message counter will say that there are 10 unread messages (10 topics). To see the number of messages in each topic you have to go in and you never know, unless you manually count how many messages all the topics add up to.

I haven't seen an option in the app to count messages instead of topics.

My question is NOT related to the badge on the app which does indicate all unread messages (including archived chats. That value is fine. I'm asking about the badge on folders located in the sidebar)

[john-preston]

@ciltocruz Folders always show the number of chats, ignoring the "count unread messages" setting, that was done together with mobile apps, the same way counters work there. For now it works like that, intended.

[ciltocruz]

@john-preston you're right! Sorry for the question, so.

[dsent]

@Aokromes sorry, but the original issue is not about messages vs topics described above, and if you have to close it, it should probably be closed as fixed, not as "not planned". Because, well, it's fixed by @23rd's patches.