tdesktop icon indicating copy to clipboard operation
tdesktop copied to clipboard

[Question] Does "Mute forever" action actually mutes a chat for one year?

Open ali-shamakhi opened this issue 1 year ago • 4 comments

Recently, I have noticed that if I mute a chat using the "Mute forever" action:

image

the context menu of the chat will show 1y in front of the "Unmute" action:

image

This behavior is new, as my old muted chats are not like this.

Is this a new limitation of the Telegram API?

ali-shamakhi avatar Sep 13 '22 06:09 ali-shamakhi

I don't see any limitation from the API schema side, but apparently tdesktop's default muting time is 84600 * 365 seconds (one year):

https://github.com/telegramdesktop/tdesktop/blob/9933d1ff3a5156aeba470f2407344f90d030633d/Telegram/SourceFiles/data/notify/data_peer_notify_settings.h#L32

https://github.com/telegramdesktop/tdesktop/blob/898edad09ba93b8cceaa4613b2d53a81cb3d5762/Telegram/SourceFiles/menu/menu_mute.cpp#L84-L120

(these might not be the relevant snippet of code that handles how the chats are muted)

RememberTheAir avatar Sep 13 '22 07:09 RememberTheAir

Is this a new limitation of the Telegram API?

I would say that the server has expanded the limits. All previous years, the tdesktop was sending muting of chat to the server for 365 days and it was recognized as "forever". Now 365 days should really mute for that period.

Please check the latest beta, it should be better now.

23rd avatar Sep 16 '22 06:09 23rd

So, shouldn't the UI reflect the situation correctly? For example, the "Mute forever" action should be renamed to "Mute for 1 year".

Although, I prefer being able to actually mute a chat forever (if possible).

ali-shamakhi avatar Sep 19 '22 04:09 ali-shamakhi

@ali-shamakhi

Please check the latest beta, it should be better now.

john-preston avatar Sep 20 '22 08:09 john-preston

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

github-actions[bot] avatar Oct 05 '22 00:10 github-actions[bot]