tdesktop icon indicating copy to clipboard operation
tdesktop copied to clipboard

Message width computed wrong way

Open LexaGV opened this issue 1 year ago • 25 comments

Steps to reproduce

When I receive message with video, full message width is adjusted to be the same as video! As a result, long text become narrow, high rectangle.

Expected behaviour

Message width must be as wide as possible! (as it counted without video)

Actual behaviour

Message text is shown with the same width as video.

Operating system

Windows 7 x64

Version of Telegram Desktop

4.1.1

Installation source

Static binary from official website

Logs

No response

LexaGV avatar Aug 31 '22 17:08 LexaGV

I believe this is intended from design perspective

ilya-fedin avatar Sep 01 '22 04:09 ilya-fedin

@ilya-fedin Emm... sorry, what is correspondence between mentioned "design" and inconvenience during reading? Obviously message width MUST be comfortable and take as much as possible space (like message w/o video).

LexaGV avatar Sep 01 '22 09:09 LexaGV

I don't quite understand your question. What I said is this works as intended most likely. You may not like it, but this is not a bug.

ilya-fedin avatar Sep 01 '22 09:09 ilya-fedin

@LexaGV To do that something should be done with the video preview. Some Telegram apps fill the left and right areas that appear from the text width increase by a darkened blurred video frame, but this is rather complicated to implement in tdesktop.

This issue may be changed to a feature request (with an enhancement tag). This is a known feature request that may be tracked here.

john-preston avatar Sep 01 '22 09:09 john-preston

@ilya-fedin : sorry, if you don't understand the problem, use service of more advanced developers. Problem is quite clear - message text takes same width as video, what leads to VERY NARROW COLUMN to read text. What you don't understand there?? I have wide LCD, but read text like it's written on toilet roll. This is image how message looks in narrow edges: https://i.ibb.co/hBpLChs/telega-Suxx.webp

I prefer to see message in full width (as you count width when message doesn't have video).

LexaGV avatar Sep 01 '22 09:09 LexaGV

@john-preston You don't catch a problem. Video doesn't correspond to problem at all. Problem is message underneath - it takes TOO NARROW SPACE. Look at pic I refer above.

LexaGV avatar Sep 01 '22 09:09 LexaGV

What you don't understand there??

I don't understand this question:

what is correspondence between mentioned "design" and inconvenience during reading?

ilya-fedin avatar Sep 01 '22 09:09 ilya-fedin

This is image how message looks in narrow edges: https://i.ibb.co/hBpLChs/telega-Suxx.webp

That's not a bug

ilya-fedin avatar Sep 01 '22 09:09 ilya-fedin

I prefer to see message in full width

Feel free to submit a feature request (don't forget to search for existing ones first).

ilya-fedin avatar Sep 01 '22 09:09 ilya-fedin

@ilya-fedin : then be more precise when you ask. This question is "half-answer" on idea that your "design" has no correspondence to idea that message reading should be EASY. If you know this term, there is "usability" word - in this case usability is BAD.

LexaGV avatar Sep 01 '22 09:09 LexaGV

Maybe. But this still works as intended and therefore not a bug.

ilya-fedin avatar Sep 01 '22 09:09 ilya-fedin

I have no time and knowledge to dig in code. I request to fix bug (in usability) when message width CALCULATED WRONG WAY. It's literally one line of code. For people who develop messenger it's 1 minute job.

LexaGV avatar Sep 01 '22 09:09 LexaGV

Repetition "it's not a bug" just confirms that usability is not your skill, please invite more professional developers. IT IS A BUG. Bug in usability.

LexaGV avatar Sep 01 '22 09:09 LexaGV

As @john-preston said, it's more complex: wider bubbles mean wider black borders what is no-go from design perspective. Someone has to implement blur background instead of black borders first. So this is a new feature rather than a bug fix.

ilya-fedin avatar Sep 01 '22 09:09 ilya-fedin

Sorry, what "black borders" are you talking about?? Nobody asks to touch video - it takes own width and it's OK. But TEXT BELOW THE VIDEO - there you have a problem, it is shown in too narrow space equal to video width. Video width must NOT be used when text width is computed. Quite simple!

LexaGV avatar Sep 01 '22 09:09 LexaGV

If you want more space for text, you need to make the bubble wider. When you make the bubble wider, you need to fill the space between video size and the bubble size.

ilya-fedin avatar Sep 01 '22 09:09 ilya-fedin

@LexaGV The video is the upper part of the message bubble, the text is the lower part. So the media on top and the text at the bottom take the same width. To increase it the same approach as mobile apps use should be used. It could be done, but it's not a quick task.

john-preston avatar Sep 01 '22 09:09 john-preston

So what? Is it so hard problem for developer???? Look how it should be: https://i.ibb.co/52f89Kv/Telega-proper-view.webp (of course for prettiness you can align video in center)

LexaGV avatar Sep 01 '22 09:09 LexaGV

Look how it should be

LOL. No, it's definitely not how it should be.

ilya-fedin avatar Sep 01 '22 09:09 ilya-fedin

@ilya-fedin I don't need your incompetent LOL - I need comfortable reading zone + video.

LexaGV avatar Sep 01 '22 09:09 LexaGV

I propose to show your competence everyone and implement that on your own. The community will thank you.

ilya-fedin avatar Sep 01 '22 09:09 ilya-fedin

@LexaGV Well, such implementation won't be accepted, sorry. The one with narrow video and wide bubble parts above and below (or only below) the video.

john-preston avatar Sep 01 '22 09:09 john-preston

I'd say this may be considered a feature request to support the same solution that iOS app provides.

john-preston avatar Sep 03 '22 04:09 john-preston

Isn't this a duplicate of https://github.com/telegramdesktop/tdesktop/issues/16838 then?

ilya-fedin avatar Sep 03 '22 04:09 ilya-fedin

@ilya-fedin Hmm, I've looked now, and iOS app only applies blurred-parts workaround to photos, while for videos it just cust top and bottom parts in-chat when caption is present. Interesting, maybe this could be done on TDesktop too.

john-preston avatar Sep 03 '22 05:09 john-preston

Issue is NOT resolved, why you close it?? Main issue is not how you move video across text, but MAKE TEXT WIDER. It's totally annoying when narrow video followed a huge column with narrow text. Text MUST be as wide as possible. Is it so hard to guess?

LexaGV avatar Oct 11 '22 07:10 LexaGV

@LexaGV because in the latest versions text under the video takes as much width as a regular text message, without a video. So the issue is fixed.

john-preston avatar Oct 14 '22 04:10 john-preston