tdesktop icon indicating copy to clipboard operation
tdesktop copied to clipboard

OSX: Ctrl + Option + "Б" and Ctrl + Option + "Ю" not works

Open dm3ch opened this issue 3 years ago • 9 comments

Steps to reproduce

Try to print dot or comma using described below key combinations on macOS standard Russian layout.

Expected behaviour

. should be printed when ctrl+option+> (ю) pressed , should be printed when ctrl+option+< (б) pressed

Actual behaviour

Nothing printed when specified key combinations pressed

Operating system

MacOS 12.4

Version of Telegram Desktop

v4.1

Installation source

Static binary from official website

Logs

No response

dm3ch avatar Aug 12 '22 22:08 dm3ch

Actually, there is an old already closed issue describing the same problem https://github.com/telegramdesktop/tdesktop/issues/2468

The only information I found there is to look into https://github.com/telegramdesktop/tdesktop/issues/1060 , but I wasn't able to find any related info.

P.S. Key combinations described in this issue are not some custom shortcuts, but a official way of printing this characters on macOS standard Russian layout (for me it works in all applications except Telegram Desktop)

dm3ch avatar Aug 12 '22 22:08 dm3ch

Have you checked other Qt applications like qBittorrent or VLC?

ilya-fedin avatar Aug 13 '22 00:08 ilya-fedin

Have you checked other Qt applications like qBittorrent or VLC?

Just checked in VLC 3.0.17.3 in playlist search input these combinations work fine.

dm3ch avatar Aug 13 '22 01:08 dm3ch

It's better to check qBittorrent (the one that built with Qt 6). I don't know what Qt version VLC uses on macOS, but on Windows it still uses Qt 4 while tdesktop uses Qt 6, no surprise if there would be big differences in behavior.

ilya-fedin avatar Aug 13 '22 01:08 ilya-fedin

qBittorent 4.4.3.1 (on QT 6) problem reproduced. Probably you are right and this is a QT issue.

dm3ch avatar Aug 13 '22 01:08 dm3ch

Created an issue in QT bug tracker, maybe we would find some help there - https://bugreports.qt.io/browse/QTBUG-106393

dm3ch avatar Sep 07 '22 18:09 dm3ch

It seems VLC on macOS doesn't use Qt: https://en.wikipedia.org/wiki/VLC_media_player#Interfaces So it's not really known whether Qt 4 is affected or not

ilya-fedin avatar Sep 07 '22 18:09 ilya-fedin

QT closed the issue as fixed. They wrote that fix version is: 6.5.0 Beta1

dm3ch avatar Sep 18 '22 11:09 dm3ch

How fast

ilya-fedin avatar Sep 18 '22 12:09 ilya-fedin

Created PR with attempt to bump QT version for MacOS build.

I'm not sure if I done this right, but I need workflow approves to try to build it

dm3ch avatar Dec 05 '22 21:12 dm3ch

It's sadly not that simple, first the patches in https://github.com/desktop-app/patches should be updated as there are new API uses that break macOS 10.12+ build in Qt. Then ui_window_mac, main_window_mac should be prepared for winId change in runtime as it changes now due to QtWidgets refactoring in Qt 6.4 to support RHI. Maybe changing the order of some calls would be enough though, so OpenGL is initialized before native window creation.

Testing with workflows is not a good thing to do as they go 6+ hours.

ilya-fedin avatar Dec 05 '22 21:12 ilya-fedin

QT closed the issue as fixed. They wrote that fix version is: 6.5.0 Beta1

Are you sure that the 6.4.1 version fixes the problem?

23rd avatar Dec 05 '22 22:12 23rd

It seems the fix will be only in 6.4.2

ilya-fedin avatar Dec 05 '22 22:12 ilya-fedin

Ah, it's actually in 6.4.1, but the fix broke some other IM-related thing and now there's yet another fix that will be in 6.4.2

ilya-fedin avatar Dec 05 '22 22:12 ilya-fedin

Ahh, you are right, just realized that fix version is marked as 6.5.0-Beta1.

About using pipelines for test purposes - I got your point. It seems I'm too much out of scope/experience to do this version bump by myself. :(

dm3ch avatar Dec 05 '22 22:12 dm3ch

By the way, if you are already managing patches for Qt in a separate repo, maybe it would be easier to backport a bugfix as a patch to currently used version instead of working on a QT version upgrade?

dm3ch avatar Dec 05 '22 23:12 dm3ch

I think I can check later how difficult it would be to update the QT version.

23rd avatar Dec 05 '22 23:12 23rd

Just checked today, dot and comma key combinations finally works, TY 🎉

dm3ch avatar Dec 07 '22 11:12 dm3ch