Introduce TDESKTOP_DISABLE_LEGACY_TGVOIP

[klemensn]

Originally from Alt Linux[0], OpenBSD has so far adapted the removal of tgvoip in the official net/tdesktop build.

tgcalls provides everything needed for calls; audio/video/desktop sharing calls have been working fine across different operating systems and telegram desktop/mobile versions without problems.

0: http://www.sisyphus.ru/cgi-bin/srpm.pl/Sisyphus/telegram-desktop/getpatch/1

[ilya-fedin]

sharing calls have been working fine across different operating systems and telegram desktop/mobile versions without problems.

Even with Telegram X for Android? :thinking:

[klemensn]

Even with Telegram X for Android? 🤔

No, @noiseless and I just confirmed that calls fail to establish between telegram-desktop 3.5.2 without tgvoip on OpenBSD/amd64 and Telegram 0.24.2.1471-arm64-v8a on Android 11.

Other non-OpenBSD clients (Android FOSS app, Linux desktop) work just fine, so Telegram X seems to still require tgvoip.

[ilya-fedin]

There's no real need to, it was discussed in the tdesktop contributions group that there will be no possibility to build without libtgvoip. All tdesktop builds should support it until @john-preston decides it's the time to drop the support.

[rakino]

Thanks for the explanation!

Another question is that, I wonder if there's a bugreport related to this issue mentioned in the packaging guide:

so the calls will crash due to two webrtc libraries being in one address spacey

I didn't find that while searching through, would you mind giving me a pointer?

Thanks again :)

[ilya-fedin]

This shouldn't ever happen if you let tdesktop to build libtgvoip. If you're trying to build libtgvoip with its own build scripts, it's unlikely to ever work right as they're abandoned.