tdesktop icon indicating copy to clipboard operation
tdesktop copied to clipboard

Fix #17324 appears to have regressed, issue #16884 is back

Open gbcox opened this issue 2 years ago • 21 comments

Steps to reproduce

Problem was fixed, but with today's update (January 14, 2022) #16884 is back.

Expected behaviour

Upgrade successful

Actual behaviour

Update is downloaded, but is corrupted. You have to delete the Telegram directory and reinstall manually from the website.

Operating system

Fedora Linux

Version of Telegram Desktop

3.4.4 Beta

Installation source

Static binary from official website

Logs

No response

gbcox avatar Jan 15 '22 02:01 gbcox

There were no changes to the updater since then

ilya-fedin avatar Jan 15 '22 07:01 ilya-fedin

That's odd. The update a few weeks ago worked perfectly, today the update failed with the same issue of corrupted/partial download. Had to delete the Telegram directory, go to the website, download the tsetup then extract the Telegram directory.

gbcox avatar Jan 15 '22 07:01 gbcox

I have a feel that this is going to be like the famous Linux kernel bug 12309

ilya-fedin avatar Jan 15 '22 07:01 ilya-fedin

On the bright side there is an easy workaround. It's more of an annoyance than anything else.

gbcox avatar Jan 15 '22 07:01 gbcox

@gbcox Does it reproduce from scratch? Like, download the previous version from github releases and try to autoupdate in Settings.

john-preston avatar Jan 15 '22 09:01 john-preston

I was affected by #16884 and I didn't have any problems updating to 3.4.4 beta.

ArchLinux + KDE Plasma

Marzal avatar Jan 15 '22 15:01 Marzal

@john-preston Hey John, that worked - so maybe I had something in my configuration left over from the previous installations. Noticed this time I had to reconfigure. Can we keep this open until the next release to be sure? Thanks!

gbcox avatar Jan 15 '22 20:01 gbcox

Guess it was some kind of fluke with my configuration, just upgraded to 3.4.5 beta with no issues, so closing. Thanks much!

gbcox avatar Jan 17 '22 03:01 gbcox

...or the issue was never fixed for your case and appears randomly

ilya-fedin avatar Jan 17 '22 04:01 ilya-fedin

I have the same issue. Updated to 3.5 today via updater and the binary has been corrupted. Kernel 5.15.6, Fedora 34. So I guess the #16884 still persists.

xelld avatar Feb 01 '22 08:02 xelld

same problem here. Fedora 35 FWIW.

Update button in telegram, pushed it hoping it would work THIS time...it didn't.

Seems to be broken most upgrades for me.

here is one thing to note. I looked at the binary after I hit update, and the size was off.

Notice the sizes before and after. They Telegram app was different size.

mwoodson@blanka:~/Apps/Telegram➤ ll
total 84M
drwxrwxr-x. 1 mwoodson mwoodson   30 Feb  1 09:07 .
drwxrwxr-x. 1 mwoodson mwoodson  478 Jan 26 10:48 ..
-rw-r--r--. 1 mwoodson mwoodson  78M Feb  1 09:07 Telegram
-rwxr-xr-x. 1 mwoodson mwoodson 5.1M Feb  1 09:07 Updater
◀ 09:07.50 Tue Feb 01 2022 ▶                                                    
mwoodson@blanka:~/Apps/Telegram➤ cd ..
◀ 09:08.08 Tue Feb 01 2022 ▶                                                    
mwoodson@blanka:~/Apps➤ mv ~/Downloads/tsetup.3.5.0.tar.xz .
◀ 09:08.13 Tue Feb 01 2022 ▶                                                    
mwoodson@blanka:~/Apps➤ tar xvf tsetup.3.5.0.tar.xz 
Telegram/
Telegram/Updater
Telegram/Telegram
◀ 09:08.18 Tue Feb 01 2022 ▶                                                    
mwoodson@blanka:~/Apps➤ rm tsetup.3.5.0.tar.xz
◀ 09:08.20 Tue Feb 01 2022 ▶                                                    
mwoodson@blanka:~/Apps➤ ll Telegram 
total 118M
drwxrwxr-x. 1 mwoodson mwoodson   30 Jan 31 18:18 .
drwxrwxr-x. 1 mwoodson mwoodson  478 Feb  1 09:08 ..
-rwxr-xr-x. 1 mwoodson mwoodson 112M Jan 31 18:17 Telegram
-rwxr-xr-x. 1 mwoodson mwoodson 5.1M Jan 31 18:15 Updater

mwoodson avatar Feb 01 '22 14:02 mwoodson

Can anybody with the problem please check if you:

  • download 3.4.8 from GitHub releases: http://github.com/telegramdesktop/tdesktop/releases/v3.4.8
  • unpack it to a separate folder ~/TestUpdate
  • create an empty folder ~/TestUpdate/TelegramForcePortable (so that this separate version won't kill your auth session)
  • launch the app from terminal with ~/TestUpdate/Telegram -debug
  • try to update it in Settings to 3.5.0

Will it work that way? If not - can you .zip and upload logs here from ~/TestUpdate/TelegramForcePortable/DebugLogs ?

john-preston avatar Feb 01 '22 14:02 john-preston

Can anybody with the problem please check if you:

  • download 3.4.8 from GitHub releases: http://github.com/telegramdesktop/tdesktop/releases/v3.4.8
  • unpack it to a separate folder ~/TestUpdate
  • create an empty folder ~/TestUpdate/TelegramForcePortable (so that this separate version won't kill your auth session)
  • launch the app from terminal with ~/TestUpdate/Telegram -debug
  • try to update it in Settings to 3.5.0

Will it work that way? If not - can you .zip and upload logs here from ~/TestUpdate/TelegramForcePortable/DebugLogs ?

I am one who has issues upgrading every time the button appears. So I tried these steps, and I couldn't get it to fail. I tried it 3 times and the upgrade worked every time. Happy to try something else if suggested.

mwoodson avatar Feb 01 '22 20:02 mwoodson

Can anybody with the problem please check if you:

  • download 3.4.8 from GitHub releases: http://github.com/telegramdesktop/tdesktop/releases/v3.4.8
  • unpack it to a separate folder ~/TestUpdate
  • create an empty folder ~/TestUpdate/TelegramForcePortable (so that this separate version won't kill your auth session)
  • launch the app from terminal with ~/TestUpdate/Telegram -debug
  • try to update it in Settings to 3.5.0

Will it work that way? If not - can you .zip and upload logs here from ~/TestUpdate/TelegramForcePortable/DebugLogs ?

I am one who has issues upgrading every time the button appears. So I tried these steps, and I couldn't get it to fail. I tried it 3 times and the upgrade worked every time. Happy to try something else if suggested.

Same here. Apparently, something is happening in the existing install that doesn't show up when you try to recreate from scratch - and I'm guessing whatever that is, is happening during the auto-update download. So, how about:

  1. Turning off auto-update
  2. Wait for notification that update is available
  3. Restart Telegram with the debug feature
  4. Then turn on auto-update

I would think that should capture the issue... at least, worth a shot unless anyone else has a better idea.

gbcox avatar Feb 01 '22 20:02 gbcox

You can enable debug logs permanently (until the next update) by typing "debugmode" in Settings. Then wait for the next update and look into "~/.local/share/TelegramDesktop/DebugLogs".

john-preston avatar Feb 02 '22 12:02 john-preston

Updated today to 3.7.1 without any problems.

xelld avatar Apr 21 '22 07:04 xelld

Failed for me on 3.7.1. I am having a real hard time collecting the debug on this too.

mwoodson avatar Apr 21 '22 11:04 mwoodson

Well, i have checked it again manually (3.6.1 to 3.7.1), it still works. But i observed the problem while updating 3.6 to 3.6.1 several days ago, magic.

xelld avatar Apr 21 '22 13:04 xelld

Okay, it's broken, again.

xelld avatar Apr 26 '22 07:04 xelld

We're still waiting for the logs

ilya-fedin avatar Apr 27 '22 18:04 ilya-fedin

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

github-actions[bot] avatar Oct 25 '22 02:10 github-actions[bot]