tdesktop icon indicating copy to clipboard operation
tdesktop copied to clipboard

Messages pinned before a group's conversion to supergroup cannot be unpinned/dismissed

Open RememberTheAir opened this issue 3 years ago • 15 comments

Steps to reproduce

  1. create a group
  2. send and pin some messages
  3. perform one of the actions that trigger the group's conversion to supergroup, such as changing the chat history visibility
  4. optionally send some messages and pin them

Expected behaviour

The messages sent and pinned before the conversion to supergroup are displayed in the pinned message forever, without the possibility to unpin or dismiss them. They stay there forever

Actual behaviour

I'm not sure about what should be the proper behavior when this happens. The android app (and also Telegram X) simply doesn't show pinned messages belonging to the chat history prior the conversion to supergroup. I guess this is the intended behavior

Alternatively, tdesktop could still show the "old" messages in the pinned messages list, but should provide an option to dismiss/unpin them (even if it's just for me). Right now, they stay there indefinitely, without the possibility to unpin them, which sometimes is annoying

Configuration

Operating system: any (pop!os, windows 10)

Version of Telegram Desktop: 2.7.5

RememberTheAir avatar May 27 '21 10:05 RememberTheAir

Related card on the suggestions platform: https://bugs.telegram.org/c/711

RememberTheAir avatar May 28 '21 13:05 RememberTheAir

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

stale[bot] avatar Nov 24 '21 16:11 stale[bot]

Yes, it's still an issue

RememberTheAir avatar Nov 24 '21 16:11 RememberTheAir

Just run into the same problem. I pinned a message, just after the creation of the group. Using the desktop app on windows 11 I cannot pin/unpin it and does not show as pinned on mobile devices. But stays there on desktop app.

Would love for this issue to be fixed because I created a new group just because I wanted a clean start and I epic failed 🤣

socket462 avatar Dec 11 '21 09:12 socket462

Heavy plus to this one. The issue is totally reproducable on desktop client. It seems that desktop app is using different approach when it loads pinned messaged from API.

Expected behavior: e.g. Android app is behaving in a more predictable way — it shows only messages that have been pinned after the conversion to a supergroup.

Configuration Operating system: whatever Version of Telegram Desktop: 3.7.3 (from Flatpak)

bandikoot avatar May 11 '22 22:05 bandikoot

Checked some more stuff — this issue is most likely not cache-related:

  • Settings -> Advanced -> Manage local storage -> Clear all — won't solve
  • Logout, log back in — won't solve
  • Delete entire app (flatpak uninstall org.telegram.desktop), install again — won't solve

@ilya-fedin, would you mind taking a look?

bandikoot avatar May 11 '22 23:05 bandikoot

Why do you ping me? :thinking:

ilya-fedin avatar May 12 '22 00:05 ilya-fedin

Judging by other issues, you seem to be quite a good reviewer of what's worth fixing (:

Sorry if it caused any unnecessary disturbance

bandikoot avatar May 12 '22 00:05 bandikoot

I really know only Linux-specific code in tdesktop and this issue is not related to such code as far as I can see. And, moreover, this issue sounds like a server-side limitation. Once group is converted to supergroup, old posts become read-only and apparently no one can't do anything with that.

ilya-fedin avatar May 12 '22 00:05 ilya-fedin

Once group is converted to supergroup, old posts become read-only and apparently no one can't do anything with that.

Hah, nice.

I looked into Telegram/SourceFiles/dialogs/dialogs_pinned_list.cpp and it looks quite clean & straightforward about what it's doing. Maybe, mobile clients contain some sort of hacks (filters for read-only pinned messages?) to elliminate the described behavior.

Sad to realize that the problem tends to vanish among other issues. Could someone at least add a "bug" label to it?

bandikoot avatar May 12 '22 01:05 bandikoot

Could someone at least add a "bug" label to it?

It won't change anything...

ilya-fedin avatar May 12 '22 01:05 ilya-fedin

@bandikoot Those are about pinned chats :)

I'll look into it later today.

john-preston avatar May 12 '22 04:05 john-preston

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

github-actions[bot] avatar Nov 09 '22 02:11 github-actions[bot]

unstale

RememberTheAir avatar Nov 09 '22 07:11 RememberTheAir

+

bandikoot avatar Nov 09 '22 09:11 bandikoot

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

github-actions[bot] avatar May 10 '23 01:05 github-actions[bot]

unstale

RememberTheAir avatar May 10 '23 06:05 RememberTheAir

Yes, it is still an issue

olekiiia avatar Jun 20 '23 13:06 olekiiia

Still happening. Still very annoying.

Someone could add a warning to the inconspicuous "Labels" toggle that triggers this unwanted migration.

MahmoudAlyuDeen avatar Nov 18 '23 23:11 MahmoudAlyuDeen

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

github-actions[bot] avatar May 17 '24 01:05 github-actions[bot]

image

MahmoudAlyuDeen avatar May 17 '24 01:05 MahmoudAlyuDeen