[Feature Request] Allow 'trust this domain' to skip 'Open this link?' confirmations

[mvolfik]

Is your feature request related to a problem?

There are news channels such as @enkocz which post headlines as text links. However, confirming link click every time is quite annoying.

Describe the solution you'd like

Add a third option 'Trust this domain' which skips this dialog for all links matching this domain. This should also be stored somewhere in settings to allow removing such preference.

Describe alternatives you've considered

One other idea which comes to my mind is 'Trust links from this channel/sender', but I believe domain-based trust is more beneficial and adding both options would clutter the dialog too much.

Additional context

[mvolfik]

Forgot to add - my inspiration for this was discord, which handles it like this: However, they apparently don't have this list available in settings, but only via accessing local storage (it's built in electron) (https://support.discord.com/hc/en-us/community/posts/360034700712-Untrusting-a-Domain)

[stale[bot]]

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

[mvolfik]

Gah, the insanity of stalebots. No, I didn't lose interest, but I understand that this is lower priority and is likely in the backlog

[Aokromes]

Gah, the insanity of stalebots. No, I didn't lose interest, but I understand that this is lower priority and is likely in the backlog

not insanity, even a lot of people may hate then it helps us to close already fixed issues.

[raine]

Desperately needed. Option to disable them altogether would be sufficient for me as well. I only click trusted links anyway, so no need for telegram's babysitting.

[mvolfik]

@raine the thing is you can't know if it is a trusted link until you click it (the url isn't shown, the link is under some text) - so the dialog itself is good. but then for some domains you know it becomes annoying (but then later it could save you when it appears when you expected to be going to a trusted domain)

[raine]

I mean by trusted link also that the source is trusted to only send legitimate links.

All I'm saying is that if the implementation cost of trusted domains is too high, I'd be happy with extremely hidden config option to remove these altogether.

[soredake]

https://bugs.telegram.org/c/17971

[vitaly-zdanevich]

Patch, on Gentoo Linux you can put it to /etc/portage/patches/net-im/telegram-desktop/open-this-link-confirmation-drop.patch (file name can be any) with such content:

diff --git i/Telegram/SourceFiles/core/click_handler_types.cpp w/Telegram/SourceFiles/core/click_handler_types.cpp
index 9e290988f..503fe050a 100644
--- i/Telegram/SourceFiles/core/click_handler_types.cpp
+++ w/Telegram/SourceFiles/core/click_handler_types.cpp
@@ -119,21 +119,21 @@ void HiddenUrlClickHandler::Open(QString url, QVariant context) {
 		|| url.startsWith(u"internal:"_q, Qt::CaseInsensitive)) {
 		UrlClickHandler::Open(url, QVariant::fromValue([&] {
 			auto result = context.value<ClickHandlerContext>();
 			result.mayShowConfirmation = !base::IsCtrlPressed();
 			return result;
 		}()));
 	} else {
 		const auto parsedUrl = url.startsWith(u"tonsite://"_q)
 			? QUrl(url)
 			: QUrl::fromUserInput(url);
-		if (UrlRequiresConfirmation(parsedUrl) && !base::IsCtrlPressed()) {
+		if (false && !base::IsCtrlPressed()) {
 			const auto my = context.value<ClickHandlerContext>();
 			if (!my.show) {
 				Core::App().hideMediaView();
 			}
 			const auto displayed = parsedUrl.isValid()
 				? parsedUrl.toDisplayString()
 				: url;
 			const auto displayUrl = !IsSuspicious(displayed)
 				? displayed
 				: parsedUrl.isValid()

and rebuild with emerge -a telegram-desktop

I created the ticket on Gentoo to add this patch for a USE flag https://bugs.gentoo.org/955901