telegram-bot icon indicating copy to clipboard operation
telegram-bot copied to clipboard

fix: Rails 8.1 incompatibility config_accessor

Open mprokopov opened this issue 2 months ago • 7 comments

Logger functionality in ActionController implemented using AbstractController::Logger class. Following change fixes incompatibility with Rails 8.1.

Resolves https://github.com/telegram-bot-rb/telegram-bot/issues/263

mprokopov avatar Oct 15 '25 07:10 mprokopov

I get

Could not find compatible versions

Because every version of telegram-bot depends on activesupport >= 4.0, < 8.1
  and activejob >= 8.1.0 depends on activesupport = 8.1.0,
  every version of telegram-bot is incompatible with activejob >= 8.1.0.
So, because Gemfile depends on activejob = 8.1.0
  and Gemfile depends on telegram-bot >= 0,
  version solving has failed.

thomaswitt avatar Oct 22 '25 10:10 thomaswitt

I've tested this PR, works great for me. Would appreciate a merge, @printercu

thomaswitt avatar Nov 01 '25 13:11 thomaswitt

Test fails

printercu avatar Nov 01 '25 14:11 printercu

@mprokopov would you update the test? I am still on this PR

thomaswitt avatar Nov 21 '25 18:11 thomaswitt

@printercu most likely the bug goes away if you update your ruby version

thomaswitt avatar Nov 27 '25 14:11 thomaswitt

the test seems to fail on presumably unrelated problem but, I don't have an idea how to retrigger it w/o changing the code

Coveralls encountered an exception: OpenSSL::SSL::SSLError

mprokopov avatar Nov 28 '25 09:11 mprokopov

it's basically a known bug with a openssl incompatibility if you don't explicitly include openssl as a gem with older ruby versions.

thomaswitt avatar Nov 29 '25 21:11 thomaswitt