iotagent-ul icon indicating copy to clipboard operation
iotagent-ul copied to clipboard

HTTP Swagger

Open fiqare-secmotic opened this issue 5 years ago • 8 comments

This pull request contains improvements made by the Secmotic team for iotagent-ul. These improvements are part of the fiQare project, which is based on ISO 25010 to improve software quality. More info: https://fiqare.eu/

Swagger is provided for HTTP protocol in: <server_host>:7896/api-docs

Note: npm install is needed

All test in Travis has been passed successfully and the coverage in Coveralls remains the same.

fiqare-secmotic avatar Dec 16 '19 10:12 fiqare-secmotic

fixed in 8f66e1a31efaf583c99a9625d92709ffe5057c25

fiqare-secmotic avatar Dec 23 '19 08:12 fiqare-secmotic

fixed in 29983d140c7944c0eedb23db1ace00b2e55e724d

fiqare-secmotic avatar Dec 23 '19 09:12 fiqare-secmotic

fixed in 29983d1

LGTM

jason-fox avatar Dec 23 '19 09:12 jason-fox

fixed in 8f66e1a

LGTM

jason-fox avatar Dec 23 '19 09:12 jason-fox

At the present moment (January 7th, 2019), there are some comment threads (some from @jason-fox and some from e) not yet answered/fixed so I understand the work on this PR is ongoing.

@fiqare-secmotic , is my understanding correct?

fgalan avatar Jan 07 '20 20:01 fgalan

Please have a look to the travis CI report. Several linting errors appear:

lib/bindings/HTTPBindings.js: line 440, col 124, Line is too long.
lib/bindings/HTTPBindings.js: line 458, col 122, Line is too long.
lib/bindings/HTTPBindings.js: line 474, col 135, Line is too long.
lib/bindings/HTTPBindings.js: line 516, col 129, Line is too long.
lib/bindings/HTTPBindings.js: line 527, col 135, Line is too long.

fgalan avatar Jan 21 '20 10:01 fgalan

After merging PR #415 I'm afraid some merging conflict have arisen in this PR. Fortunatelly, the solution seems easy, detailed by @jason-fox at https://github.com/telefonicaid/iotagent-manager/pull/171#issuecomment-650021937

all you need to do is merge and accept yours

Thereafter

npm i
npm run lint

And fix any es6 errors raised. (Alternatively you could disable the failed rule for your files if necessary)

Sorry for the incoveniences

fgalan avatar Jul 03 '20 11:07 fgalan

thanks for the info! @fgalan

fiqare-secmotic avatar Jul 07 '20 09:07 fiqare-secmotic