iotagent-node-lib icon indicating copy to clipboard operation
iotagent-node-lib copied to clipboard

Published 20 hours ago • verified publisher icon telefonicaid

Added Feature/config groups

Open Madhu-NEC opened this issue 4 years ago • 13 comments

Added code for iot/configGroups (#752)

Madhu-NEC avatar Dec 02 '20 04:12 Madhu-NEC

Hi @fgalan ,

All the test cases are passing on my local setup but here 1 test case is failed. Please find below screenshot. test_result_latest

Could you please let me know if there is any additional steps are required?

Thanks!

Madhu-NEC avatar Dec 02 '20 13:12 Madhu-NEC

Could you please let me know if there is any additional steps are required?

I did a re-launch and everything went ok. It seems it was a glitch.

fgalan avatar Dec 03 '20 12:12 fgalan

Hi @fgalan, I have only added the comments in the files as mentioned here . As per my understanding, the failure of test case is not due to the modifications at 41ee27c .The re-launch is required for failed test case. Please let me know your opinion.

Madhu-NEC avatar Dec 14 '20 11:12 Madhu-NEC

Hi @fgalan , I have resolved the conflicts. Please let me know if anything is pending.

Madhu-NEC avatar Dec 17 '20 10:12 Madhu-NEC

@fgalan Gentle Reminder!!

chandradeep11 avatar Dec 22 '20 09:12 chandradeep11

Hi @fgalan , @AlvaroVega ,

Thanks for your support. I have only resolved the conflicts in e224135. Till cffa723, travis was passing all the test cases. As per my understanding, re-run of travis is required. Kindly let me know if any additional steps are required for travis to go well.

Madhu-NEC avatar Feb 12 '21 10:02 Madhu-NEC

I have only resolved the conflicts in e224135. Till cffa723, travis was passing all the test cases. As per my understanding, re-run of travis is required. Kindly let me know if any additional steps are required for travis to go well.

GitActions (which recently replaced travis) re-executed. All the tests back to OK.

I'm afraid we haven't had the time yet to review this pull request. Its size and complexity are delaying the review. Sorry for the inconvenience.

fgalan avatar Feb 12 '21 12:02 fgalan

But tests are still able to work with /iot/configGroups or /iot/services, aren't they?

Yes @AlvaroVega , test cases for both the endpoints are working fine.

Madhu-NEC avatar Jun 30 '21 06:06 Madhu-NEC

Hi @fgalan , Sorry for the delayed response. I have updated the PR with incorporated suggestions. If the PR is OK now, then please merge the PR into master.

Madhu-NEC avatar Jun 30 '21 08:06 Madhu-NEC

Hi @fgalan , Sorry for the delayed response. I have updated the PR with incorporated suggestions. If the PR is OK now, then please merge the PR into master.

A large work is currently ongoing to remove de NGSI-v1 functionality (which is obsolete) from the code base in PR https://github.com/telefonicaid/iotagent-node-lib/pull/995. As a consequence of this work, all the NGSI-v1 tests will be removed (and maybe some NGSI-v2 tests get added to fill existing "gaps" between both).

Thus, I think is better to wait to merging that PR, as many of the tests in this one (PR #954) will be removed and there is no point if reviewing them now.

fgalan avatar Jul 16 '21 09:07 fgalan

PR https://github.com/telefonicaid/iotagent-node-lib/pull/995 removing NGSIv1 was merged. Now, conflicts on test files can be resolved.

mapedraza avatar Oct 07 '21 14:10 mapedraza

@fgalan @mapedraza rebased the #954 PR and updated as per PR #995 Please find the link of the PR https://github.com/telefonicaid/iotagent-node-lib/pull/1198.

Sunny-NEC avatar Feb 07 '22 05:02 Sunny-NEC

@fgalan @mapedraza rebased the #954 PR and updated as per PR #995 Please find the link of the PR #1198.

So this PR should be closed in favour of PR #1198?

fgalan avatar Feb 07 '22 15:02 fgalan

overpassed by https://github.com/telefonicaid/iotagent-node-lib/pull/1375#issuecomment-1736903343

mapedraza avatar Sep 27 '23 13:09 mapedraza