fiware-cygnus icon indicating copy to clipboard operation
fiware-cygnus copied to clipboard

[cygnus-ngsi][NGSIRestHandler] Do not throw exceptions, just trace them

Open frbattid opened this issue 7 years ago • 2 comments

NGSIRestHandler traces and throws the following exceptions:

ngsiresthandler

They must be just traced.

frbattid avatar May 05 '17 12:05 frbattid

@frbattid As per my understanding, the fix of this issue is to put error logs instead of throw exception at the mentioned line number of NGSIRestHandler.java. But at line number 233 of NGSIRestHandler.java, HTTPBadRequestException is thrown if "/" is not added in servicepath. So if we fix the issue then in this case the error log will be logged but code will execute successfully with incorrect servicepath.

Please confirm my understanding

chandradeep11 avatar Jun 26 '19 04:06 chandradeep11

I understand that the work consists in properly trace exception using the logging library instead of getting a stack trace but that the code flow will be as it is now (I mean if the execution flow is not interrupted due to an incorrect service path that shouldn't change).

Just guessing. Honestly, I'm not sure about what @frbattid has in mind regarding this :)... (and I'm afraid he is no longer active on Cygnus)

fgalan avatar Jun 26 '19 19:06 fgalan