Oliver Mannion

Results 233 comments of Oliver Mannion

As per above, to get started, I've raised #710 for a basic LSP server. I've also created a yet to be published, but working, basic vscode extension that uses the...

Hi @mawkler `typos-lsp` binaries are now published on the `tekumara/typos-vscode` [Github release page](https://github.com/tekumara/typos-vscode/releases). If you have any questions, please feel free to raise an issue over there.

Hi @Kludex these were added by `ruff format .` which I ran to satisfy the [failing build](https://github.com/encode/starlette/actions/runs/7443169078/job/20247672655), I can try and remove them.

Yes your example errors because of the [tighter bound mentioned above](https://github.com/encode/starlette/pull/2403#discussion_r1444167214), eg: ``` ❯ mypy starlette/test.py starlette/test.py:1: error: Module "starlette.applications" does not explicitly export attribute "Request" [attr-defined] starlette/test.py:13: error: Argument...

Yes that will pass type checks. I haven't changed the dictionary key which is still `Any` ie: the key isn't tied to the handler `Callable` as it is with the...

Hi @ThirVondukr your snippet is essentially what the PR implements. The one difference is the PR's `ExceptionType` is bound to Exception to prevent non-Exception types from being used in the...

Hi @Kludex, Thanks for taking a look again! 1. currently these of your above cases are not addressed in this PR and will not error as the comment indicates they...

After merging in master again, the tests are failing on this PR (and other PRs too) because of a change unrelated to this PR: > + mypy starlette tests starlette/templating.py:125:...

Duckdb doesn't support this convenience yet (raised [here](https://github.com/duckdb/duckdb/discussions/11962)) but this could be supported in fakesnow with a transform.

FYI - would also be great to filter on this metadata when using the `read_deployments` client method.