website icon indicating copy to clipboard operation
website copied to clipboard

Triggers and EventListeners documentation - TriggerFlow do not display

Open fckbo opened this issue 2 years ago • 8 comments

Expected Behavior

  1. When accessing https://tekton.dev/docs/triggers/
  2. At the end of the "How does Triggers work?" section a TriggerFlow diagram should display

Actual Behavior

The TriggerFlow diagram does not display

Steps to Reproduce the Problem

See expected Behavior section above

Additional Info

The html artefact coresponding to the error

<img src="../images/TriggerFlow.svg" alt="TriggerFlow">

fckbo avatar Apr 17 '22 00:04 fckbo

@ranbirkatal: GitHub didn't allow me to assign the following users: binkkatal.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/assign @binkkatal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar May 23 '22 02:05 tekton-robot

/assign @binkkatal

binkkatal avatar May 23 '22 02:05 binkkatal

fyi @binkkatal this issue looks like a duplicate of https://github.com/tektoncd/website/issues/340 See some of the work that has already be done for that issue

AlanGreene avatar May 23 '22 11:05 AlanGreene

@AlanGreene , will verify and post and update

binkkatal avatar Jun 02 '22 05:06 binkkatal

It still looks like this 😞:

image

vovtz avatar Jul 29 '22 08:07 vovtz

@vovtz , still needs to cover up some test cases

binkkatal avatar Aug 02 '22 13:08 binkkatal

@binkkatal Who needs to do that?

vovtz avatar Aug 02 '22 19:08 vovtz

@vovtz i am working on it, did some changes in https://github.com/in2tivetech/tekton-website/commit/5cfe97f15c811fdf197cd72a6f4efbaf4dfae3a9 , need to check up against some test cases.

binkkatal avatar Aug 03 '22 02:08 binkkatal

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Nov 01 '22 03:11 tekton-robot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot avatar Dec 01 '22 03:12 tekton-robot

/remove-lifecycle stale

Still as relevant as initially

vovtz avatar Dec 01 '22 10:12 vovtz

/remove-lifecycle rotten

The documentation still doesn’t show the image

vovtz avatar Dec 01 '22 10:12 vovtz

Fixed in #490

geriom avatar Jan 30 '23 18:01 geriom