triggers
triggers copied to clipboard
tektoncd
Support dry-run in the admission webhook
Expected Behavior
I can kubectl diff tekton triggers resources
Actual Behavior
On the plumbing repo:
$ kubectl diff -k tekton/resources
Error from server (InternalError): Internal error occurred: admission webhook "triggers-webhook.tekton.dev" does not support dry run
andreafrittoli@galadriel:/go/src/github.com/tektoncd/plumbing (buildid)$ ll tekton/resources/
total 96
drwxr-xr-x 11 andreafrittoli wheel 352 2 Nov 17:24 .
drwxr-xr-x 8 andreafrittoli wheel 256 31 Oct 15:40 ..
-rw-r--r-- 1 andreafrittoli wheel 3039 2 Nov 17:24 image-build-trigger.yaml
-rw-r--r-- 1 andreafrittoli wheel 5669 23 Oct 11:08 install_and_test_tekton_release.yaml
-rw-r--r-- 1 andreafrittoli wheel 6915 23 Oct 11:08 install_tekton_release.yaml
-rw-r--r-- 1 andreafrittoli wheel 304 31 Oct 15:18 kustomization.yaml
-rw-r--r-- 1 andreafrittoli wheel 3877 24 Oct 16:55 pipeline-nightly-build-trigger.yaml
-rw-r--r-- 1 andreafrittoli wheel 1923 24 Oct 16:55 pipeline-nightly-release-logs-trigger.yaml
-rw-r--r-- 1 andreafrittoli wheel 2965 23 Oct 11:08 prerelease_checks.yaml
-rw-r--r-- 1 andreafrittoli wheel 2471 24 Oct 16:55 save-release-logs.yaml
-rw-r--r-- 1 andreafrittoli wheel 5480 23 Oct 11:08 test_tekton_release.yaml
Steps to Reproduce the Problem
Additional Info
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Send feedback to tektoncd/plumbing.
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close
Send feedback to tektoncd/plumbing.
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten
Send feedback to tektoncd/plumbing.
@tekton-robot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity. Reopen the issue with
/reopen. Mark the issue as fresh with/remove-lifecycle rotten./close
Send feedback to tektoncd/plumbing.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@vdemeester: Reopened this issue.
In response to this:
/remove-lifecycle rotten /remove-lifecycle stale /reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Send feedback to tektoncd/plumbing.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.
/lifecycle stale
Send feedback to tektoncd/plumbing.
It looks like this issue may have been resolved by updating the webhook yaml config? It doesn't seem like the same error happens when I run it on a more up to date version. It looks like plumbing has other issues where resources is a directory now instead of a yaml file. If I run the same command against triggers it looks like it works.
@afrittoli can you see if this is still an issue and let me know if the steps to reproduce are different? I was looking at working on this if it is still an issue.
