triggers icon indicating copy to clipboard operation
triggers copied to clipboard
verified publisher icon tektoncd

Fix cannot create ingress for getting-started guide

Open marniks7 opened this issue 3 years ago • 4 comments

Changes

Fixing image

Create-ingress-run were failing with cannot create resource "ingresses" in API group "networking.k8s.io"

Providing additional grants in order to be able to create ingress

After the fix: image

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [x] Includes tests (if functionality changed/added)
  • [x] Includes docs (if user facing)
  • [x] Commit messages follow commit message best practices
  • [x] Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

marniks7 avatar Aug 12 '22 04:08 marniks7

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: marniks7 (080e69d6bedbc4f2e8cfa173b56dbb9da2c3c9c9)

linux-foundation-easycla[bot] avatar Aug 12 '22 04:08 linux-foundation-easycla[bot]

Hi @marniks7. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Aug 12 '22 04:08 tekton-robot

/ok-to-test

savitaashture avatar Aug 12 '22 08:08 savitaashture

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Aug 12 '22 08:08 tekton-robot

/lgtm

dibyom avatar Aug 16 '22 15:08 dibyom