results
results copied to clipboard
Adds PostgreSQL Database Table Schema to Configuration
Changes
This allows a schema to be set on the table instead of assuming public
.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
- [x] Has Docs included if any changes are user facing
- [x] Has Tests included if any functionality added or changed
- [x] Tested your changes locally (if this is a code change)
- [x] Follows the commit message standard
- [x] Meets the Tekton contributor standards (including functionality, content, code)
- [x] Has a kind label. You can add a comment on this PR that contains
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep - [x] Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
- [x] Release notes contain the string "action required" if the change requires additional action from users switching to the new release
Release Notes
PostgreSQL table schema can be set using the DB_SCHEMA environment and configuration variable.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: chriscannon / name: Chris Cannon (9d90c6cc6e428c2d0bdfb29a99164ae7cb5f4517, 5f0c21456e95132c9af17f8dc352a0b26ba41f98)
Hi @chriscannon. Thanks for your PR.
I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/kind feature
/ok-to-test
The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
cmd/api/main.go | 11.9% | 11.7% | -0.2 |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: adambkaplan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [adambkaplan]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
@adambkaplan could you also add a lgtm label so that it can pass the CI validation? Thanks!
@chriscannon: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.