results icon indicating copy to clipboard operation
results copied to clipboard

Results API server should watch configmap

Open khrm opened this issue 1 year ago • 3 comments

Expected Behavior

The results API server should have a watcher for the configmap.

Actual Behavior

The results API server doesn't take into account changes done to configmap. We need to delete the API server pod and wait for a restart. This is different from other components' behavior.

khrm avatar Sep 25 '23 12:09 khrm

/kind feature

khrm avatar Sep 25 '23 12:09 khrm

Should also watch secrets, because the DB details and TLS details.

sayan-biswas avatar Oct 19 '23 12:10 sayan-biswas

@khrm IMO this should be broken down in two parts and implemented in different project. For example.

  • In tekton results project, watching the configuration through FSevents should be implemented and it should only allow changing parameters that doesn't require restart, like LogLevel. Changing other parameters like Port and Dbname would break the service if we only restart the Pod. Moreover, if there is only one replica running, this would impact the service for some time, which can in the middle of log transmission and that is non-recoverable.
  • The other configuration changes which involve restarting the API server should be implemented in the Tekton Operator project, as that manages the lifecycle of the whole tekton results service.

sayan-biswas avatar Nov 14 '23 21:11 sayan-biswas