results icon indicating copy to clipboard operation
results copied to clipboard

Fix file permission mismatch for Postgres statefulset

Open xinnjie opened this issue 1 year ago • 12 comments

Changes

This fix the issue https://github.com/tektoncd/results/issues/522 Kubelet will modify the ownership and permissions of volume to 1001 which Postgres uses after setting securityContext.fsGroup. This pr will helper users who want to try out Results not encounter file permission issues.

Submitter Checklist

/kind bug These are the criteria that every PR should meet, please check them off as you review them:

  • [ ] Has Docs included if any changes are user facing
  • [ ] Has Tests included if any functionality added or changed
  • [x] Tested your changes locally (if this is a code change)
  • [x] Follows the commit message standard
  • [x] Meets the Tekton contributor standards (including functionality, content, code)
  • [x] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [x] Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [ ] Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

xinnjie avatar Jul 15 '23 07:07 xinnjie

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign alan-ghelardi after the PR has been reviewed. You can assign the PR to them by writing /assign @alan-ghelardi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Jul 15 '23 07:07 tekton-robot

Hi @xinnjie. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Jul 15 '23 07:07 tekton-robot

/cc @avina @enarha

xinnjie avatar Jul 15 '23 07:07 xinnjie

@xinnjie: GitHub didn't allow me to request PR reviews from the following users: avina.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @avina @enarha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Jul 15 '23 07:07 tekton-robot

/release-note-none

xinnjie avatar Jul 16 '23 15:07 xinnjie

@xinnjie: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Jul 16 '23 15:07 tekton-robot

/ok-to-test

sayan-biswas avatar Jul 17 '23 03:07 sayan-biswas

/release-note-none

xinnjie avatar Jul 17 '23 04:07 xinnjie

@xinnjie: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Jul 17 '23 04:07 tekton-robot

/release-note-none

xinnjie avatar Jul 17 '23 04:07 xinnjie

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Oct 15 '23 17:10 tekton-robot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot avatar Nov 14 '23 18:11 tekton-robot