results icon indicating copy to clipboard operation
results copied to clipboard

Make cel2sql generic using View abstraction

Open RafaeLeal opened this issue 1 year ago • 5 comments

Changes

This PR makes the cel2sql package more generic, introducing a new View abstraction. This allows us to decouple what we expose for the Results' API filters and the database structure.

I believe it also makes changes in our database safer since we don't have to think of all kinds of filters that would use each column of the db table. The idea is to make the changes and support in the CEL filters more deliberate.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [ ] Has Docs included if any changes are user facing
  • [x] Has Tests included if any functionality added or changed
  • [ ] Tested your changes locally (if this is a code change)
  • [ ] Follows the commit message standard
  • [ ] Meets the Tekton contributor standards (including functionality, content, code)
  • [x] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [ ] Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [ ] Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Refactor cel2sql into a generic and extensible View abstraction

RafaeLeal avatar Jun 07 '23 16:06 RafaeLeal

/kind misc

alan-ghelardi avatar Jul 01 '23 16:07 alan-ghelardi

@RafaeLeal I left a few comments mostly about style and some parts of the code that I'd prefer to leave as before (tests, for example). You need to rebase the pr and write down release notes.

alan-ghelardi avatar Jul 01 '23 16:07 alan-ghelardi

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Jul 24 '23 17:07 tekton-robot

@RafaeLeal: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Jul 29 '23 17:07 tekton-robot

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Oct 27 '23 18:10 tekton-robot