plumbing icon indicating copy to clipboard operation
plumbing copied to clipboard

Fix peribolos webhook

Open afrittoli opened this issue 4 years ago • 10 comments

Expected Behavior

The webhook used by periobolos is configured to webhook.periobolos.dogfooding.tekton.dev.

Actual Behavior

The event listener is set to LoadBalancer mode. The public IP from the service is not configured as webhook in the commity repo, so no updates happen.

Additional Info

  1. Change the service type to NodePort
  2. Setup an ingress, similar to the CI one
  3. Define the name webhook.periobolos.dogfooding.tekton.dev on Netlify side. We have an open issue about automating this step, so it's manual until that is implemented.
  4. Create the webhook in the community repo. We might want to automate the creation of the webhook too but it's manual for now.

As a side, there is a task for that in the triggers getting started about creating the webhook. We should move that into the catalog, and setup a cronjob that maintains the webhooks using that.

afrittoli avatar Oct 02 '20 11:10 afrittoli

/cc @vdemeester

afrittoli avatar Oct 02 '20 11:10 afrittoli

As a side, there is a task for that in the triggers getting started about creating the webhook. We should move that into the catalog, and setup a cronjob that maintains the webhooks using that.

I think https://github.com/tektoncd/catalog/pull/243 does that.

dibyom avatar Oct 02 '20 16:10 dibyom

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Dec 31 '20 17:12 tekton-robot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot avatar Jan 30 '21 17:01 tekton-robot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot avatar May 07 '21 11:05 tekton-robot

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar May 07 '21 11:05 tekton-robot

/remove-lifecycle rotten

afrittoli avatar Oct 18 '21 09:10 afrittoli

/lifecycle frozen

afrittoli avatar Oct 18 '21 09:10 afrittoli

/reopen

afrittoli avatar Oct 18 '21 09:10 afrittoli

@afrittoli: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Oct 18 '21 09:10 tekton-robot