Move remaining prow jobs to GitHub Actions

[AlanGreene]

presubmits

https://github.com/tektoncd/plumbing/blob/94a5d5c3db90db8420875c4957cb053da46e654a/prow/config.yaml#L369

• [ ] tektoncd/chains
  • [ ] pull-tekton-chains-build-tests https://github.com/tektoncd/chains/pull/1446
  • [ ] pull-tekton-chains-unit-tests https://github.com/tektoncd/chains/pull/1446
  • [ ] pull-tekton-chains-go-coverage https://github.com/tektoncd/chains/pull/1447
• [x] tektoncd/operator
  • [x] pull-tekton-operator-go-coverage https://github.com/tektoncd/operator/pull/2913
• [ ] tektoncd/catalog
  • [ ] pull-tekton-catalog-build-tests
  • [ ] pull-tekton-catalog-unit-tests
  • [x] pull-tekton-catalog-integration-tests https://github.com/tektoncd/catalog/pull/1345
• [x] tektoncd/resolution https://github.com/tektoncd/plumbing/pull/2843
  • [x] pull-tekton-resolution-build-tests
  • [x] pull-tekton-resolution-unit-tests
  • [x] pull-tekton-resolution-integration-tests
• [x] tektoncd/triggers
  • [x] pull-tekton-triggers-build-tests https://github.com/tektoncd/triggers/pull/1889
  • [x] pull-tekton-triggers-unit-tests https://github.com/tektoncd/triggers/pull/1889
  • [x] pull-tekton-triggers-go-coverage https://github.com/tektoncd/triggers/pull/1891
• [ ] tektoncd/ahmetb-gen-crd-api-reference-docs
  • [ ] pull-tekton-gen-crd-api-reference-docs-build-tests

postsubmits

https://github.com/tektoncd/plumbing/blob/94a5d5c3db90db8420875c4957cb053da46e654a/prow/config.yaml#L787

• [ ] tektoncd/plumbing
  • [ ] post-tekton-plumbing-upload-testgrid-config
• [ ] tektoncd/catlin
  • [ ] post-tekton-catlin-go-coverage https://github.com/tektoncd/catlin/pull/65
• [ ] tektoncd/chains
  • [ ] post-tekton-chains-go-coverage https://github.com/tektoncd/chains/pull/1447
• [x] tektoncd/operator
  • [x] post-tekton-operator-go-coverage https://github.com/tektoncd/operator/pull/2913
• [x] tektoncd/pipeline
  • [x] post-tekton-pipeline-go-coverage https://github.com/tektoncd/pipeline/pull/9055
• [x] tektoncd/triggers
  • [x] post-tekton-triggers-go-coverage https://github.com/tektoncd/triggers/pull/1891
• [x] tektoncd/results
  • [x] post-tekton-results-go-coverage https://github.com/tektoncd/results/pull/1126

periodics

https://github.com/tektoncd/plumbing/blob/94a5d5c3db90db8420875c4957cb053da46e654a/prow/config.yaml#L912

• [ ] ci-tekton-pipeline-upgrade-tests
• [ ] periodic-tekton-catalog-integration-tests
• [ ] ci-tekton-pipeline-feature-flag-tests

[AlanGreene]

@afrittoli should we also remove this considering the presubmit job was removed in https://github.com/tektoncd/plumbing/pull/2840/files#diff-43597815f705840f0d74fd38408b1dfab023521863d730099df2dad36f7183a5L395-L416? https://github.com/tektoncd/plumbing/blob/94a5d5c3db90db8420875c4957cb053da46e654a/prow/config.yaml#L788-L813

[AlanGreene]

Do we want / need to keep the postsubmit go-coverage jobs?

[vdemeester]

Do we want / need to keep the postsubmit go-coverage jobs?

I am fine not having them anymore and have another solution for coverage.

[AlanGreene]

I think I have a solution, just need time to test it fully. Hopefully later today 🤞

[AlanGreene]

I have a working go coverage replacement using https://github.com/marketplace/actions/go-unit-test-coverage-report

The skulls might be a bit much, but it's only for each 10% decrease so should be rare 😅

It uses workflow artifacts to store the previous coverage, so no need to run the tests twice in the workflow or to deal with external storage.

The detailed report by file is collapsed by default.

It doesn't support any customisation of the comment. Is this OK as-is or should we consider something else?

[vdemeester]

@AlanGreene I think we can dry-run this and see if it's good for us, but I think it's ok yes.

[AlanGreene]

PR for chains which is where I initially tested it (on my fork): https://github.com/tektoncd/chains/pull/1447 However chains appears to have problems with its tests unrelated to my changes.

and for pipeline: https://github.com/tektoncd/pipeline/pull/9055

I'll create PRs for the rest this evening.

We'll need fgrosse/go-coverage-report@* added to the actions allow-list. It also uses tj-actions/changed-files@* which is already allowed.

[AlanGreene]

All of the coverage jobs have been migrated to GHA workflows now and I've updated the checklist above to reflect the current status of the remaining jobs.