pipeline icon indicating copy to clipboard operation
pipeline copied to clipboard

fix: stepaction resolution should respect task's namespace

Open waveywaves opened this issue 7 months ago • 3 comments

Changes

When resolving StepActions using the Cluster resolver, the system should always use the Task's namespace rather than falling back to the TaskRun's namespace. Prior to this StepActions were incorrectly being looked up in the Pipeline's namespace instead of the Task's namespace. fixes

fixes #https://github.com/tektoncd/pipeline/issues/8380

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • [ ] Has Tests included if any functionality added or changed
  • [ ] pre-commit Passed
  • [ ] Follows the commit message standard
  • [ ] Meets the Tekton contributor standards (including functionality, content, code)
  • [ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

waveywaves avatar May 19 '25 12:05 waveywaves

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from waveywaves after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar May 19 '25 12:05 tekton-robot

/kind bug

waveywaves avatar May 19 '25 12:05 waveywaves

We probably need to do this for all resolvers and types.

vdemeester avatar May 19 '25 15:05 vdemeester

CLA Missing ID CLA Not Signed

  • :x: The email address for the commit (d9d66da154f3ca0240ebceded1b09d5ba85c83ed) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.