pipeline icon indicating copy to clipboard operation
pipeline copied to clipboard

feat: override task timeouts in pipelineruns

Open waveywaves opened this issue 9 months ago • 21 comments

Changes

/fixes https://github.com/tektoncd/pipeline/issues/7752

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [x] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • [x] Has Tests included if any functionality added or changed
  • [ ] pre-commit Passed
  • [ ] Follows the commit message standard
  • [ ] Meets the Tekton contributor standards (including functionality, content, code)
  • [ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

waveywaves avatar Mar 11 '25 14:03 waveywaves

/kind feature

waveywaves avatar Mar 11 '25 14:03 waveywaves

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 93.8% -0.9

tekton-robot avatar Mar 11 '25 14:03 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 93.8% -0.9

tekton-robot avatar Mar 11 '25 15:03 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 93.8% -0.9

tekton-robot avatar Mar 28 '25 23:03 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.4% -0.2

tekton-robot avatar Mar 29 '25 01:03 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.4% -0.2

tekton-robot avatar Mar 29 '25 02:03 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.4% -0.2

tekton-robot avatar Mar 29 '25 02:03 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.4% -0.2

tekton-robot avatar Mar 31 '25 20:03 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.4% -0.2

tekton-robot avatar Mar 31 '25 20:03 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.4% -0.2

tekton-robot avatar Mar 31 '25 20:03 tekton-robot

cc @vdemeester @afrittoli @aThorp96 ready for review

waveywaves avatar Mar 31 '25 20:03 waveywaves

cc @afrittoli @twoGiants @abayer

waveywaves avatar Apr 28 '25 21:04 waveywaves

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.4% -0.2

tekton-robot avatar May 07 '25 12:05 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 93.5% -1.2
pkg/apis/pipeline/v1/taskrun_validation.go 97.4% 97.5% 0.0
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.4% 97.5% 0.0

tekton-robot avatar May 07 '25 12:05 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.1% -0.6
pkg/apis/pipeline/v1/taskrun_validation.go 97.4% 97.5% 0.0
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go 97.2% 97.7% 0.6
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.4% 98.1% 0.7

tekton-robot avatar May 07 '25 12:05 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.1% -0.6
pkg/apis/pipeline/v1/taskrun_validation.go 97.4% 97.5% 0.0
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go 97.2% 97.7% 0.6
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.4% 98.1% 0.7

tekton-robot avatar May 07 '25 12:05 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.1% -0.6
pkg/apis/pipeline/v1/taskrun_validation.go 97.4% 97.5% 0.0
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go 97.2% 97.7% 0.6
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.4% 98.1% 0.7

tekton-robot avatar May 07 '25 12:05 tekton-robot

/retest

waveywaves avatar Jun 03 '25 09:06 waveywaves

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.0% -0.7
pkg/apis/pipeline/v1/taskrun_validation.go 97.4% 97.5% 0.0
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go 97.2% 97.7% 0.6
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.4% 98.1% 0.7

tekton-robot avatar Jun 03 '25 13:06 tekton-robot

Such a useful feature, should we add a release note to recommend it to everyone? 😆

l-qing avatar Jun 14 '25 15:06 l-qing

ping @waveywaves 🙏🏼

vdemeester avatar Jul 21 '25 14:07 vdemeester

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.0% -0.7
pkg/apis/pipeline/v1/taskrun_validation.go 97.4% 97.5% 0.0
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go 97.2% 97.7% 0.6
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.4% 98.1% 0.7

tekton-robot avatar Jul 29 '25 20:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.0% -0.7
pkg/apis/pipeline/v1/taskrun_validation.go 97.4% 97.5% 0.0
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 95.7% 95.8% 0.0
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 89.7% 89.8% 0.1
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go 97.2% 97.9% 0.8
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.4% 98.1% 0.7
pkg/reconciler/pipelinerun/pipelinerun.go 91.8% 91.9% 0.1

tekton-robot avatar Jul 29 '25 22:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.0% -0.7
pkg/apis/pipeline/v1/taskrun_validation.go 97.4% 97.5% 0.0
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 95.7% 95.8% 0.0
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 89.7% 89.8% 0.1
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go 97.2% 97.9% 0.8
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.4% 98.1% 0.7
pkg/reconciler/pipelinerun/pipelinerun.go 91.8% 91.9% 0.1

tekton-robot avatar Jul 29 '25 22:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.0% -0.7
pkg/apis/pipeline/v1/taskrun_validation.go 97.4% 97.5% 0.0
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 95.7% 95.8% 0.0
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 89.7% 89.8% 0.1
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go 97.2% 97.9% 0.8
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.4% 98.1% 0.7
pkg/reconciler/pipelinerun/pipelinerun.go 91.8% 91.9% 0.1

tekton-robot avatar Jul 29 '25 22:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.0% -0.7
pkg/apis/pipeline/v1/taskrun_validation.go 97.4% 97.5% 0.0
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 95.7% 95.8% 0.0
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 89.7% 89.8% 0.1
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go 97.2% 97.9% 0.8
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.4% 98.1% 0.7
pkg/reconciler/pipelinerun/pipelinerun.go 91.8% 91.9% 0.1

tekton-robot avatar Jul 29 '25 22:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.0% -0.7
pkg/apis/pipeline/v1/taskrun_validation.go 97.4% 97.5% 0.0
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 95.7% 95.8% 0.0
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 89.7% 89.8% 0.1
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go 97.2% 97.9% 0.8
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.4% 98.1% 0.7
pkg/reconciler/pipelinerun/pipelinerun.go 91.8% 91.9% 0.1

tekton-robot avatar Jul 29 '25 22:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.0% -0.7
pkg/apis/pipeline/v1/taskrun_validation.go 97.4% 97.5% 0.0
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 95.7% 95.8% 0.0
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 89.7% 89.8% 0.1
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go 97.2% 97.9% 0.8
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.4% 98.1% 0.7
pkg/reconciler/pipelinerun/pipelinerun.go 91.8% 91.9% 0.1

tekton-robot avatar Jul 29 '25 22:07 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.5% 0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go 94.7% 94.0% -0.7
pkg/apis/pipeline/v1/taskrun_validation.go 97.4% 97.5% 0.0
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go 95.7% 95.8% 0.0
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 89.7% 89.8% 0.1
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go 97.2% 97.9% 0.8
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.4% 98.1% 0.7
pkg/reconciler/pipelinerun/pipelinerun.go 91.8% 91.9% 0.1

tekton-robot avatar Jul 29 '25 22:07 tekton-robot

/approve /meow

vdemeester avatar Jul 30 '25 09:07 vdemeester