pipeline icon indicating copy to clipboard operation
pipeline copied to clipboard

ci: allow users apart from ones with write permissions to trigger /retest

Open waveywaves opened this issue 9 months ago • 4 comments

Currently users with only write permissions can trigger retests with the /retest flag. collaborator folk such as myself have to rely on maintainer intervention to ensure that flakes aren't giving false positives wrt if the test is failing. Being able to hit the /retest will allow users to develop more easily on the repository. Initially we can allow collaborators to user /retest. Afterwards we can introduce /ok-to-test to mark PRs which will allow outside collaborators to contribute and use /retest without unnecessary intervention.

  • [ ] implement /retest for collaborators
  • [ ] implement /ok-to-test for wider audience as a boolean check which will then allow the outside contributor to user /retest

based on discussions in https://github.com/tektoncd/pipeline/pull/8616#issuecomment-2697652079

waveywaves avatar Mar 04 '25 20:03 waveywaves

I believe adding workflow_dispatch should resolve this as well. https://github.com/tektoncd/pipeline/pull/8624

leshikus avatar Mar 06 '25 18:03 leshikus

@leshikus workflow_dispatch still requires write permissions.

See https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/manually-running-a-workflow#configuring-a-workflow-to-run-manually

Write access to the repository is required to perform these steps.

AlanGreene avatar Mar 06 '25 22:03 AlanGreene

I was able to run tests with workflow_dispatch in my own fork

still requires write permissions.

leshikus avatar Mar 18 '25 10:03 leshikus

Yes as you have write permissions on your fork, you own that repo.

AlanGreene avatar Mar 18 '25 12:03 AlanGreene