pipeline
pipeline copied to clipboard
tektoncd
Upgraded Remote Resolution Framework
This PR implements an updated resolver framework with slight updates. This is to avoid backwards incompatibility while implementing TEP-0154.
The current framework works directly with Params. For example, the interface has ValidateParams and Resolve methods which take in Params as arguments. Now that we also need to pass in a URL, we need to add new methods and change function signatures which leads to API incompatibility with existing custom resolvers. As a result, when users upgrade to new version of Tekton Pipelines, they will be forced to implement new methods because of the interface changes.
This PR tries to make it future proof such that if we add new fields to the ResolutionRequestSpec, it will be handled without the need to break users.
Note Since, Resolution is still v1beta1, I think we can provide a deprecation notice to deprecate the current format.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
- [x] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
- [x] Has Tests included if any functionality added or changed
- [x] pre-commit Passed
- [x] Follows the commit message standard
- [x] Meets the Tekton contributor standards (including functionality, content, code)
- [x] Has a kind label. You can add one by adding a comment on this PR that contains
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep - [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
- [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release
Release Notes
Upgraded remote resolution framework.
/kind misc
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| internal/resolution/resource/crd_resource.go | Do not exist | 83.3% | |
| internal/resolution/resource/name.go | Do not exist | 76.2% | |
| internal/resolution/resource/request.go | Do not exist | 100.0% | |
| pkg/resolution/resolver/internal/resolutionrequest.go | Do not exist | 100.0% | |
| pkg/resolution/resolver/internal/resolutionrequest.go | Do not exist | 0.0% | |
| pkg/resolution/resolver/internal/resolutionrequest.go | Do not exist | 100.0% | |
| pkg/resolution/resolver/internal/resolutionrequest.go | Do not exist | 50.0% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| internal/resolution/resource/crd_resource.go | Do not exist | 83.3% | |
| internal/resolution/resource/name.go | Do not exist | 76.2% | |
| internal/resolution/resource/request.go | Do not exist | 100.0% | |
| pkg/resolution/resolver/internal/resolutionrequest.go | 50.0% | 0.0% | -50.0 |
| pkg/resolution/resolver/internal/resolutionrequest.go | Do not exist | 50.0% | |
| pkg/resolution/resolver/internal/resolutionrequest.go | Do not exist | 50.0% | |
| pkg/resolution/resolver/internal/resolutionrequest.go | Do not exist | 100.0% | |
| pkg/resolution/resolver/internal/resolutionrequest.go | Do not exist | 100.0% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| internal/remote/oci/resolver.go | Do not exist | 71.4% | |
| internal/remote/resolution/error.go | Do not exist | 33.3% | |
| internal/remote/resolution/request.go | Do not exist | 100.0% | |
| internal/remote/resolution/resolver.go | Do not exist | 86.2% | |
| internal/resolution/resource/crd_resource.go | Do not exist | 83.3% | |
| internal/resolution/resource/name.go | Do not exist | 76.2% | |
| internal/resolution/resource/request.go | Do not exist | 100.0% | |
| pkg/resolution/resolver/common/context.go | Do not exist | 92.9% | |
| pkg/resolution/resolver/common/errors.go | Do not exist | 17.6% | |
| pkg/resolution/resolver/internal/resolutionrequest.go | Do not exist | 50.0% | |
| pkg/resolution/resolver/internal/resolutionrequest.go | Do not exist | 100.0% | |
| pkg/resolution/resolver/internal/resolutionrequest.go | Do not exist | 25.0% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JeromeJu
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JeromeJu]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
We should change the coverage job to update the coverage comment, or delete old ones, it's way to verbose now 😅
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report